Move AlreadySpellCheckedFlag from NodeFlags to ElementFlags

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index b78667604cdfe88b1c4cefe335c77913223d2153..6b1e6d16cf91d174b624de377d6669f5a8bea859 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -167,8 +167,10 @@ void SpellChecker::toggleSpellCheckingEnabled() {
     if (!frame->isLocalFrame())
       continue;
     for (Node& node :
-         NodeTraversal::startsAt(toLocalFrame(frame)->document()->rootNode()))
-      node.setAlreadySpellChecked(false);
+         NodeTraversal::startsAt(toLocalFrame(frame)->document()->rootNode())) {
+      if (node.isElementNode())
+        toElement(node).setAlreadySpellChecked(false);

[tkent, 2016/10/14 09:16:47]

I realized this adds ElementRareData to every Elements in the document.  not
lgtm.

[Xiaocheng, 2016/10/14 09:20:12]

Setting a false ElementFlag on doesn't create ElementRareData:

void Element::setElementFlag(ElementFlags mask, bool value) {
  if (!hasRareData() && !value)
    return;
  ensureElementRareData().setElementFlag(mask, value);
}

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Eleme...

[tkent, 2016/10/14 09:26:05]

Oh, you're right!

So, ElementRareData is added to only editing host elements, INPUT, and TEXTAREA.
 lgtm

+    }
   }
 }