Move AlreadySpellCheckedFlag from NodeFlags to ElementFlags

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 149 matching lines @@
 
 void SpellChecker::toggleSpellCheckingEnabled() {
   spellCheckerClient().toggleSpellCheckingEnabled();
   if (isSpellCheckingEnabled())
     return;
   for (Frame* frame = this->frame().page()->mainFrame(); frame;
        frame = frame->tree().traverseNext()) {
     if (!frame->isLocalFrame())
       continue;
     for (Node& node :
-         NodeTraversal::startsAt(toLocalFrame(frame)->document()->rootNode()))
-      node.setAlreadySpellChecked(false);
+         NodeTraversal::startsAt(toLocalFrame(frame)->document()->rootNode())) {
+      if (node.isElementNode())
+        toElement(node).setAlreadySpellChecked(false);

[tkent, 2016/10/14 09:16:47]

I realized this adds ElementRareData to every Elements in the document.  not
lgtm.

[Xiaocheng, 2016/10/14 09:20:12]

Setting a false ElementFlag on doesn't create ElementRareData:

void Element::setElementFlag(ElementFlags mask, bool value) {
  if (!hasRareData() && !value)
    return;
  ensureElementRareData().setElementFlag(mask, value);
}

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/Eleme...

[tkent, 2016/10/14 09:26:05]

Oh, you're right!

So, ElementRareData is added to only editing host elements, INPUT, and TEXTAREA.
 lgtm

+    }
   }
 }
 
 void SpellChecker::didBeginEditing(Element* element) {
   if (!isSpellCheckingEnabled())
     return;
 
   // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited.  See http://crbug.com/590369 for more details.
   // In the long term we should use idle time spell checker to prevent
@@ skipping 937 matching lines @@
         startOfNextParagraph(createVisiblePosition(paragraphEnd));
     paragraphStart = newParagraphStart.toParentAnchoredPosition();
     paragraphEnd = endOfParagraph(newParagraphStart).toParentAnchoredPosition();
     firstIteration = false;
     totalLengthProcessed += currentLength;
   }
   return std::make_pair(firstFoundItem, firstFoundOffset);
 }
 
 }  // namespace blink