Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 2414193002: QUIC - bugfix for forced head of line blocking experiment. Guarded by ENABLED --FLAGS_quic_bugfix_f… (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_spdy_session.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 2934efef30229b9affacea0bd07ee11f71f4aca3..9201152cab9ad2a8be5d1bee0ffa6ab5ca4bfed9 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -1757,9 +1757,11 @@ TEST_P(EndToEndTest, HeadersAndCryptoStreamsNoConnectionFlowControl) {
QuicHeadersStream* headers_stream =
QuicSpdySessionPeer::GetHeadersStream(client_->client()->session());
- EXPECT_LT(
- QuicFlowControllerPeer::SendWindowSize(headers_stream->flow_controller()),
- kStreamIFCW);
+ if (!client_->client()->session()->force_hol_blocking()) {
+ EXPECT_LT(QuicFlowControllerPeer::SendWindowSize(
+ headers_stream->flow_controller()),
+ kStreamIFCW);
+ }
EXPECT_EQ(kSessionIFCW, QuicFlowControllerPeer::SendWindowSize(
client_->client()->session()->flow_controller()));
@@ -1799,12 +1801,14 @@ TEST_P(EndToEndTest, FlowControlsSynced) {
QuicSpdySessionPeer::GetHeadersStream(client_session)->flow_controller(),
QuicSpdySessionPeer::GetHeadersStream(server_session)->flow_controller());
- EXPECT_EQ(static_cast<float>(QuicFlowControllerPeer::ReceiveWindowSize(
- client_session->flow_controller())) /
- QuicFlowControllerPeer::ReceiveWindowSize(
- QuicSpdySessionPeer::GetHeadersStream(client_session)
- ->flow_controller()),
- kSessionToStreamRatio);
+ if (!client_session->force_hol_blocking()) {
+ EXPECT_EQ(static_cast<float>(QuicFlowControllerPeer::ReceiveWindowSize(
+ client_session->flow_controller())) /
+ QuicFlowControllerPeer::ReceiveWindowSize(
+ QuicSpdySessionPeer::GetHeadersStream(client_session)
+ ->flow_controller()),
+ kSessionToStreamRatio);
+ }
server_thread_->Resume();
}
« no previous file with comments | « net/quic/core/quic_spdy_session.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698