Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2414073002: Revert of [heap] Cancel tasks before tearing down the heap. (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Cancel tasks before tearing down the heap. (patchset #2 id:20001 of https://codereview.chromium.org/2413203004/ ) Reason for revert: Timeout on gc stress bot. Original issue's description: > [heap] Cancel tasks before tearing down the heap. > > BUG=chromium:654343 > > Committed: https://crrev.com/9365463d6f1fc11b2369fff63ca0ac825c61eae4 > Cr-Commit-Position: refs/heads/master@{#40272} TBR=mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:654343 Committed: https://crrev.com/f0c3a2523def5c5aebf330b870776021ccf3c409 Cr-Commit-Position: refs/heads/master@{#40279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M src/cancelable-task.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/cancelable-task.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
Created Revert of [heap] Cancel tasks before tearing down the heap.
4 years, 2 months ago (2016-10-13 16:16:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414073002/1
4 years, 2 months ago (2016-10-13 16:16:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 16:16:35 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 16:16:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0c3a2523def5c5aebf330b870776021ccf3c409
Cr-Commit-Position: refs/heads/master@{#40279}

Powered by Google App Engine
This is Rietveld 408576698