Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/isolate.cc

Issue 2414073002: Revert of [heap] Cancel tasks before tearing down the heap. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/cancelable-task.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index ef97064838ff4745e9188526b5bd287043ee2e3c..792706dc71c54dc2de0bd5f992044004d26f2b46 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2182,8 +2182,6 @@
void Isolate::Deinit() {
TRACE_ISOLATE(deinit);
- cancelable_task_manager()->CancelAndWait();
-
debug()->Unload();
FreeThreadResources();
@@ -2233,6 +2231,8 @@
delete interpreter_;
interpreter_ = NULL;
+
+ cancelable_task_manager()->CancelAndWait();
delete cpu_profiler_;
cpu_profiler_ = NULL;
« no previous file with comments | « src/cancelable-task.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698