Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 24138002: Merge 220639 "ColorChooserWin::End should act like the dialog ha..." (Closed)

Created:
7 years, 3 months ago by keishi
Modified:
7 years, 3 months ago
Reviewers:
keishi
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Merge 220639 "ColorChooserWin::End should act like the dialog ha..." > ColorChooserWin::End should act like the dialog has closed > > This is only a problem on Windows. > > When the page closes itself while the color chooser dialog is open, > ColorChooserDialog::DidCloseDialog was called after the listener has been destroyed. > > ColorChooserWin::End() will not actually close the color chooser dialog (because we can't) but act like it did so we can do the necessary cleanup. > > BUG=279263 > R=jschuh@chromium.org, pkasting@chromium.org > > Review URL: https://codereview.chromium.org/23785003 TBR=keishi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/ui/views/color_chooser_dialog.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/color_chooser_win.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
keishi
7 years, 3 months ago (2013-09-13 03:23:37 UTC) #1
keishi
7 years, 3 months ago (2013-09-13 03:24:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r222976.

Powered by Google App Engine
This is Rietveld 408576698