Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 23785003: ColorChooserWin::End should act like the dialog has closed (Closed)

Created:
7 years, 3 months ago by keishi
Modified:
7 years, 3 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

ColorChooserWin::End should act like the dialog has closed This is only a problem on Windows. When the page closes itself while the color chooser dialog is open, ColorChooserDialog::DidCloseDialog was called after the listener has been destroyed. ColorChooserWin::End() will not actually close the color chooser dialog (because we can't) but act like it did so we can do the necessary cleanup. BUG=279263 R=jschuh@chromium.org, pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220639

Patch Set 1 #

Patch Set 2 : Make ColorChooserWin::End act like it really ended #

Total comments: 2

Patch Set 3 : Changed comment #

Patch Set 4 : Changed comment #

Total comments: 2

Patch Set 5 : Changed comment again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/ui/views/color_chooser_dialog.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/color_chooser_win.cc View 1 2 3 4 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
keishi
7 years, 3 months ago (2013-08-30 01:29:33 UTC) #1
keishi
The crash in the render process needs to be addressed in a separate Blink patch ...
7 years, 3 months ago (2013-08-30 01:31:16 UTC) #2
keishi
This new patch is better. We don't have this problem on non-Windows platforms because ~WebContentsImpl ...
7 years, 3 months ago (2013-08-30 02:07:14 UTC) #3
jschuh
lgtm on the security side.
7 years, 3 months ago (2013-08-30 02:46:21 UTC) #4
keishi
Looks like ben@ is ooo. pkasting@ could you review this?
7 years, 3 months ago (2013-08-30 08:59:21 UTC) #5
Peter Kasting
LGTM https://codereview.chromium.org/23785003/diff/6001/chrome/browser/ui/views/color_chooser_win.cc File chrome/browser/ui/views/color_chooser_win.cc (right): https://codereview.chromium.org/23785003/diff/6001/chrome/browser/ui/views/color_chooser_win.cc#newcode71 chrome/browser/ui/views/color_chooser_win.cc:71: // but the internal state will be like ...
7 years, 3 months ago (2013-08-30 18:56:25 UTC) #6
keishi
Thanks! https://codereview.chromium.org/23785003/diff/6001/chrome/browser/ui/views/color_chooser_win.cc File chrome/browser/ui/views/color_chooser_win.cc (right): https://codereview.chromium.org/23785003/diff/6001/chrome/browser/ui/views/color_chooser_win.cc#newcode71 chrome/browser/ui/views/color_chooser_win.cc:71: // but the internal state will be like ...
7 years, 3 months ago (2013-08-30 19:26:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/23785003/13001
7 years, 3 months ago (2013-08-30 19:27:29 UTC) #8
Peter Kasting
https://codereview.chromium.org/23785003/diff/13001/chrome/browser/ui/views/color_chooser_win.cc File chrome/browser/ui/views/color_chooser_win.cc (right): https://codereview.chromium.org/23785003/diff/13001/chrome/browser/ui/views/color_chooser_win.cc#newcode75 chrome/browser/ui/views/color_chooser_win.cc:75: // call the listener after it has been destroyed. ...
7 years, 3 months ago (2013-08-30 19:35:47 UTC) #9
keishi
https://codereview.chromium.org/23785003/diff/13001/chrome/browser/ui/views/color_chooser_win.cc File chrome/browser/ui/views/color_chooser_win.cc (right): https://codereview.chromium.org/23785003/diff/13001/chrome/browser/ui/views/color_chooser_win.cc#newcode75 chrome/browser/ui/views/color_chooser_win.cc:75: // call the listener after it has been destroyed. ...
7 years, 3 months ago (2013-08-30 19:42:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/23785003/32001
7 years, 3 months ago (2013-08-30 19:43:03 UTC) #11
keishi
7 years, 3 months ago (2013-08-30 20:26:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 manually as r220639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698