Chromium Code Reviews
Description[NTP Client][Reland]Spacing and fixes for the sign in promo
Original issue's description:
> [NTP Client] Spacing and fixes for the sign in promo
>
> - Fixes an exception when only the sign in promo is present on the NTP
> and we attempt to make it peek
>
> - Adds 20dp space between the promo and the status card if present
>
> - Fixes to the bottom space calculation related to the dismissal of
> sibling elements.
>
> Preview: https://goo.gl/photos/94hhXK5rygGamFqt7
>
> BUG=649670, 652578
>
> Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8
> Cr-Commit-Position: refs/heads/master@{#423525}
Revert link:
> Committed: https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7
> Cr-Commit-Position: refs/heads/master@{#423644}
BUG=649670, 652578
Review-Url: https://codereview.chromium.org/2397573009
Cr-Commit-Position: refs/heads/master@{#423864}
(cherry picked from commit 1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac)
Committed: https://chromium.googlesource.com/chromium/src/+/8e8893dbdaf6fc2370c289c061bb0cf4ed420093
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||