Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2397573009: 📰 [Reland] Spacing and fixes for the sign in promo (Closed)

Created:
4 years, 2 months ago by dgn
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer, nasko
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client][Reland]Spacing and fixes for the sign in promo Original issue's description: > [NTP Client] Spacing and fixes for the sign in promo > > - Fixes an exception when only the sign in promo is present on the NTP > and we attempt to make it peek > > - Adds 20dp space between the promo and the status card if present > > - Fixes to the bottom space calculation related to the dismissal of > sibling elements. > > Preview: https://goo.gl/photos/94hhXK5rygGamFqt7 > > BUG=649670, 652578 > > Committed: https://crrev.com/e38c94250d21597b298ce1cc13cfd1a9bcd926e8 > Cr-Commit-Position: refs/heads/master@{#423525} Revert link: > Committed: https://crrev.com/08c8e081835b2ce5d2294ee36c97efc14c6340f7 > Cr-Commit-Position: refs/heads/master@{#423644} BUG=649670, 652578 Committed: https://crrev.com/1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac Cr-Commit-Position: refs/heads/master@{#423864}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase 😠 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -30 lines) Patch
M chrome/android/java/res/values/dimens.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 1 8 chunks +21 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 1 2 7 chunks +44 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SigninPromoItem.java View 1 5 chunks +29 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
dgn
Created Reland of 📰 Spacing and fixes for the sign in promo
4 years, 2 months ago (2016-10-07 13:02:18 UTC) #1
Bernhard Bauer
lgtm
4 years, 2 months ago (2016-10-07 13:31:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397573009/160001
4 years, 2 months ago (2016-10-07 15:35:23 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:160001)
4 years, 2 months ago (2016-10-07 15:41:34 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 15:44:10 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1bb1fb7f5885bfaa43b0dba4b627798cb268c7ac
Cr-Commit-Position: refs/heads/master@{#423864}

Powered by Google App Engine
This is Rietveld 408576698