Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathElement.idl

Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. (Closed)
Patch Set: Align with review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGPathElement.idl
diff --git a/third_party/WebKit/Source/core/svg/SVGPathElement.idl b/third_party/WebKit/Source/core/svg/SVGPathElement.idl
index 4b0d41ac293320c86b0d03c2538f996124511a8f..29ac0b8068990b7cfbc2cacc9cd25d9886357119 100644
--- a/third_party/WebKit/Source/core/svg/SVGPathElement.idl
+++ b/third_party/WebKit/Source/core/svg/SVGPathElement.idl
@@ -29,8 +29,5 @@
interface SVGPathElement : SVGGeometryElement {
[Measure] readonly attribute SVGAnimatedNumber pathLength;
foolip 2016/10/26 11:12:15 Can you move pathLength as well?
Shanmuga Pandi 2016/10/26 11:28:28 Yes. I am making a separate patch that. :)
- float getTotalLength();
- // TODO(foolip): SVGPoint should be DOMPoint.
- SVGPoint getPointAtLength(float distance);
unsigned long getPathSegAtLength(float distance);
foolip 2016/10/26 11:12:15 This seems to be gone from the spec, can you add a
Shanmuga Pandi 2016/10/26 11:28:28 Sure. I will make the patch for this.
};

Powered by Google App Engine
This is Rietveld 408576698