Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/svg/SVGGeometryElement.idl

Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. (Closed)
Patch Set: Align with review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-detached.html ('K') | « third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGPathElement.h » ('j') | third_party/WebKit/Source/core/svg/SVGPathElement.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
diff --git a/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl b/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
index 0977d57b02fc804916fd004476127dc63d674719..f3df49185aeb858abf6c1bd02f976ec0eb41961c 100644
--- a/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
+++ b/third_party/WebKit/Source/core/svg/SVGGeometryElement.idl
@@ -31,7 +31,9 @@
// http://www.w3.org/TR/SVG2/types.html#InterfaceSVGGeometryElement
interface SVGGeometryElement : SVGGraphicsElement {
- // TODO(foolip): SVGPoint should be DOMPoint.
boolean isPointInFill(SVGPoint point);
boolean isPointInStroke(SVGPoint point);
+ float getTotalLength();
+ // TODO(foolip): SVGPoint should be DOMPoint.
fs 2016/10/26 11:00:04 Nit: I think this can be kept at its original posi
Shanmuga Pandi 2016/10/26 11:28:28 Done.
+ SVGPoint getPointAtLength(float distance);
};
« third_party/WebKit/LayoutTests/svg/dom/SVGGeometryElement-getPointAtLength-detached.html ('K') | « third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGPathElement.h » ('j') | third_party/WebKit/Source/core/svg/SVGPathElement.idl » ('J')

Powered by Google App Engine
This is Rietveld 408576698