Chromium Code Reviews

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathElement.h

Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. (Closed)
Patch Set: Align with review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« third_party/WebKit/Source/core/svg/SVGGeometryElement.idl ('K') | « third_party/WebKit/Source/core/svg/SVGGeometryElement.idl ('k') | third_party/WebKit/Source/core/svg/SVGPathElement.idl » ('j') | third_party/WebKit/Source/core/svg/SVGPathElement.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGPathElement.h
diff --git a/third_party/WebKit/Source/core/svg/SVGPathElement.h b/third_party/WebKit/Source/core/svg/SVGPathElement.h
index 82a82d7a82dc439c1f2378a79728ac65e455d4d6..06c4dc370d2de6c31f7f2fbbb3ef296e6bfe6f13 100644
--- a/third_party/WebKit/Source/core/svg/SVGPathElement.h
+++ b/third_party/WebKit/Source/core/svg/SVGPathElement.h
@@ -40,8 +40,8 @@ class SVGPathElement final : public SVGGeometryElement {
Path asPath() const override;
Path attributePath() const;
- float getTotalLength();
- SVGPointTearOff* getPointAtLength(float distance);
+ float getTotalLength() override;
+ SVGPointTearOff* getPointAtLength(float distance) override;
unsigned getPathSegAtLength(float distance);
SVGAnimatedPath* path() const { return m_path.get(); }
« third_party/WebKit/Source/core/svg/SVGGeometryElement.idl ('K') | « third_party/WebKit/Source/core/svg/SVGGeometryElement.idl ('k') | third_party/WebKit/Source/core/svg/SVGPathElement.idl » ('j') | third_party/WebKit/Source/core/svg/SVGPathElement.idl » ('J')

Powered by Google App Engine