third_party/WebKit/Source/core/svg/SVGPathElement.h - Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathElement.h

Issue 2413753004: Move getTotalLength and getPointAtLength methods from SVGPathElement to SVGGeometryElement. (Closed)

Patch Set: Align with review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGPathElement.h

diff --git a/third_party/WebKit/Source/core/svg/SVGPathElement.h b/third_party/WebKit/Source/core/svg/SVGPathElement.h

index 82a82d7a82dc439c1f2378a79728ac65e455d4d6..06c4dc370d2de6c31f7f2fbbb3ef296e6bfe6f13 100644

--- a/third_party/WebKit/Source/core/svg/SVGPathElement.h

+++ b/third_party/WebKit/Source/core/svg/SVGPathElement.h

@@ -40,8 +40,8 @@ class SVGPathElement final : public SVGGeometryElement {

Path asPath() const override;

Path attributePath() const;

- float getTotalLength();

- SVGPointTearOff* getPointAtLength(float distance);

+ float getTotalLength() override;

+ SVGPointTearOff* getPointAtLength(float distance) override;

unsigned getPathSegAtLength(float distance);

SVGAnimatedPath* path() const { return m_path.get(); }