Chromium Code Reviews Chromium Code Reviews
Issue 2413723002:
Re-Compute slow scroll region on frameview visibility change. (Closed)
| Index: third_party/WebKit/LayoutTests/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html |
| diff --git a/third_party/WebKit/LayoutTests/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html b/third_party/WebKit/LayoutTests/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..61f90f78772dcad161aae2a905a3506083dbcb1f |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html |
| @@ -0,0 +1,38 @@ |
| +<!DOCTYPE html> |
| +<style> |
| + body { |
| + margin: 0; |
| + } |
| + iframe { |
| + height: 900px; |
| + width: 900px; |
| + margin-left: 51px; |
| + margin-top: 52px; |
| + border: none; |
| + } |
| +</style> |
| + |
| +<iframe id='iframe' src='resources/iframe-containing-non-fast-scrollables.html'></iframe> |
| + |
| +<script src="resources/non-fast-scrollable-region-testing.js"></script> |
| +<script src="../resources/run-after-layout-and-paint.js"></script> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script> |
| + async_test((t) => { |
| + var iframeWindow = document.querySelector("iframe").contentWindow; |
| + iframeWindow.addEventListener("load", () => { |
| + nonFastScrollableRects = internals.nonFastScrollableRects(document); |
| + assert_equals(nonFastScrollableRects.length, 3); |
| + |
| + var iframeelement = document.querySelector("iframe"); |
|
majidvp
2016/11/02 14:17:57
nit: s/iframeelement/iframeElement
MuVen
2016/11/02 17:07:47
Done.
|
| + iframeelement.style.visibility = 'hidden'; |
| + |
| + runAfterLayoutAndPaint(() => { |
| + nonFastScrollableRects = internals.nonFastScrollableRects(document); |
| + assert_equals(nonFastScrollableRects.length, 0); |
| + t.done(); |
| + }); |
| + }); |
| + }, "This test ensures that non-fast scrollable area is re-computed on FrameView visibility changed."); |
|
majidvp
2016/11/02 14:17:57
nit: s/changed/changes/
MuVen
2016/11/02 17:07:47
Done.
|
| +</script> |
