third_party/WebKit/LayoutTests/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html - Issue 2413723002: Re-Compute slow scroll region on frameview visibility change.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/scrollingcoordinator/donot-compute-non-fast-scrollable-region-for-hidden-frames.html

Issue 2413723002: Re-Compute slow scroll region on frameview visibility change. (Closed)

Patch Set: addressed reviiew comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/VirtualTestSuites ('k') | third_party/WebKit/LayoutTests/virtual/rootlayerscrolls/scrollingcoordinator/README.txt » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 body {

	4 margin: 0;

	5 }

	6 iframe {

	7 height: 900px;

	8 width: 900px;

	9 margin-left: 51px;

	10 margin-top: 52px;

	11 border: none;

	12 }

	13 </style>

	14

	15 <iframe id='iframe' src='resources/iframe-containing-non-fast-scrollables.html'> </iframe>

	16

	17 <script src="resources/non-fast-scrollable-region-testing.js"></script>

	18 <script src="../resources/run-after-layout-and-paint.js"></script>

	19 <script src="../resources/testharness.js"></script>

	20 <script src="../resources/testharnessreport.js"></script>

	21 <script>

	22 async_test((t) => {

	23 var iframeWindow = document.querySelector("iframe").contentWindow;

	24 iframeWindow.addEventListener("load", () => {

	25 nonFastScrollableRects = internals.nonFastScrollableRects(document);

	26 assert_equals(nonFastScrollableRects.length, 3);

	27

	28 var iframeelement = document.querySelector("iframe");
	majidvp 2016/11/02 14:17:57 nit: s/iframeelement/iframeElement nit: s/iframeelement/iframeElement MuVen 2016/11/02 17:07:47 Done. Show quoted text On 2016/11/02 14:17:57, majidvp wrote: > nit: s/iframeelement/iframeElement Done.
	29 iframeelement.style.visibility = 'hidden';

	30

	31 runAfterLayoutAndPaint(() => {

	32 nonFastScrollableRects = internals.nonFastScrollableRects(document);

	33 assert_equals(nonFastScrollableRects.length, 0);

	34 t.done();

	35 });

	36 });

	37 }, "This test ensures that non-fast scrollable area is re-computed on FrameVie w visibility changed.");
	majidvp 2016/11/02 14:17:57 nit: s/changed/changes/ nit: s/changed/changes/ MuVen 2016/11/02 17:07:47 Done. Show quoted text On 2016/11/02 14:17:57, majidvp wrote: > nit: s/changed/changes/ Done.
	38 </script>

OLD	NEW