Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 2413703002: Sync RTCDataChannel and RTCPeerConnection IDL with spec (Closed)

Created:
4 years, 2 months ago by foolip
Modified:
4 years, 2 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync RTCDataChannel and RTCPeerConnection IDL with spec No observable changes are intended. BUG=460722, 649343 R=guidou@chromium.org Committed: https://crrev.com/e70c6e15ba896a2e88d0dc05f1a20fb3d4befabf Cr-Commit-Position: refs/heads/master@{#424933}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -26 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.idl View 2 chunks +21 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCDataChannelEvent.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 3 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl View 1 chunk +12 lines, -12 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
foolip
4 years, 2 months ago (2016-10-12 14:25:26 UTC) #1
Mike West
histograms.xml/UseCounter LGTM. Please wait for guidou@ to look at the rest before landing.
4 years, 2 months ago (2016-10-12 14:31:55 UTC) #6
Guido Urdaneta
lgtm
4 years, 2 months ago (2016-10-12 14:33:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413703002/1
4 years, 2 months ago (2016-10-12 14:37:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/46892)
4 years, 2 months ago (2016-10-12 15:32:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413703002/1
4 years, 2 months ago (2016-10-12 20:56:15 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/47208)
4 years, 2 months ago (2016-10-12 21:00:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413703002/20001
4 years, 2 months ago (2016-10-12 21:22:05 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 01:44:16 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 01:46:05 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e70c6e15ba896a2e88d0dc05f1a20fb3d4befabf
Cr-Commit-Position: refs/heads/master@{#424933}

Powered by Google App Engine
This is Rietveld 408576698