Sync RTCDataChannel and RTCPeerConnection IDL with spec

third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 803 matching lines @@
 
 RTCSessionDescription* RTCPeerConnection::remoteDescription() {
   WebRTCSessionDescription webSessionDescription =
       m_peerHandler->remoteDescription();
   if (webSessionDescription.isNull())
     return nullptr;
 
   return RTCSessionDescription::create(webSessionDescription);
 }
 
-void RTCPeerConnection::updateIce(ExecutionContext* context,
-                                  const Dictionary& rtcConfiguration,
+void RTCPeerConnection::updateIce(const Dictionary& rtcConfiguration,
                                   const Dictionary& mediaConstraints,
                                   ExceptionState& exceptionState) {
   if (throwExceptionIfSignalingStateClosed(m_signalingState, exceptionState))
     return;
 
   RtcpMuxPolicy selectedRtcpMuxPolicy = RtcpMuxPolicyDefault;
   RTCConfiguration* configuration = parseConfiguration(
       rtcConfiguration, exceptionState, &selectedRtcpMuxPolicy);
 
   if (exceptionState.hadException())
@@ skipping 348 matching lines @@
   UseCounter::count(context, UseCounter::RTCPeerConnectionGetStats);
 
   ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
   ScriptPromise promise = resolver->promise();
   m_peerHandler->getStats(WebRTCStatsReportCallbackResolver::create(resolver));
 
   return promise;
 }
 
 RTCDataChannel* RTCPeerConnection::createDataChannel(
+    ExecutionContext* context,
     String label,
     const Dictionary& options,
     ExceptionState& exceptionState) {
   if (throwExceptionIfSignalingStateClosed(m_signalingState, exceptionState))
     return nullptr;
 
   WebRTCDataChannelInit init;
   DictionaryHelper::get(options, "ordered", init.ordered);
   DictionaryHelper::get(options, "negotiated", init.negotiated);
 
   unsigned short value = 0;
   if (DictionaryHelper::get(options, "id", value))
     init.id = value;
-  if (DictionaryHelper::get(options, "maxRetransmits", value))
+  if (DictionaryHelper::get(options, "maxRetransmits", value)) {
+    UseCounter::count(
+        context, UseCounter::RTCPeerConnectionCreateDataChannelMaxRetransmits);
     init.maxRetransmits = value;
-  if (DictionaryHelper::get(options, "maxRetransmitTime", value))
+  }
+  if (DictionaryHelper::get(options, "maxRetransmitTime", value)) {
+    UseCounter::count(
+        context,
+        UseCounter::RTCPeerConnectionCreateDataChannelMaxRetransmitTime);
     init.maxRetransmitTime = value;
+  }
 
   String protocolString;
   DictionaryHelper::get(options, "protocol", protocolString);
   init.protocol = protocolString;
 
   RTCDataChannel* channel = RTCDataChannel::create(
       getExecutionContext(), m_peerHandler.get(), label, init, exceptionState);
   if (exceptionState.hadException())
     return nullptr;
   RTCDataChannel::ReadyState handlerState = channel->getHandlerState();
@@ skipping 273 matching lines @@
 DEFINE_TRACE(RTCPeerConnection) {
   visitor->trace(m_localStreams);
   visitor->trace(m_remoteStreams);
   visitor->trace(m_dispatchScheduledEventRunner);
   visitor->trace(m_scheduledEvents);
   EventTargetWithInlineData::trace(visitor);
   ActiveDOMObject::trace(visitor);
 }
 
 }  // namespace blink