Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

Issue 2413693002: Rename DOM.getLayoutTreeNodes to CSS.getLayoutTreeAndStyles (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
index 32d10c0905cae9a7315a639d715a71d2d1bd0889..27f2ca08404de82f285b8cede1ca331112d60c13 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h
@@ -30,6 +30,8 @@
#ifndef InspectorDOMAgent_h
#define InspectorDOMAgent_h
+#include <unordered_map>
+
#include "core/CoreExport.h"
#include "core/events/EventListenerMap.h"
#include "core/inspector/InspectorBaseAgent.h"
@@ -124,8 +126,11 @@ class CORE_EXPORT InspectorDOMAgent final
std::unique_ptr<protocol::DOM::Node>* root) override;
void getLayoutTreeNodes(
ErrorString*,
+ std::unique_ptr<protocol::Array<String>> style_whitelist,
std::unique_ptr<protocol::Array<protocol::DOM::LayoutTreeNode>>*
- layoutTreeNodes) override;
+ layout_tree_nodes,
+ std::unique_ptr<protocol::Array<protocol::DOM::ComputedStyle>>*
+ computed_styles) override;
void collectClassNamesFromSubtree(
ErrorString*,
int nodeId,
@@ -355,8 +360,20 @@ class CORE_EXPORT InspectorDOMAgent final
Member<InspectorRevalidateDOMTask> revalidateTask();
- void visitLayoutTreeNodes(Node*,
- protocol::Array<protocol::DOM::LayoutTreeNode>&);
+ using ComputedStyleArray =
+ std::vector<std::unique_ptr<blink::protocol::DOM::ComputedStyleProperty>>;
+
+ using ComputedStylesMap = std::unordered_map<ComputedStyleArray, int>;
+
+ void visitLayoutTreeNodes(
+ Node* node,
+ protocol::Array<protocol::DOM::LayoutTreeNode>& layout_tree_nodes,
dgozman 2016/10/12 21:00:40 blink uses camelCaseNames for now.
alex clarke (OOO till 29th) 2016/10/13 20:25:10 OK :(
+ protocol::Array<String>* style_whitelist,
+ ComputedStylesMap& style_to_index_map);
+
+ int getStyleIndexForNode(Node* node,
+ protocol::Array<String>* style_whitelist,
+ ComputedStylesMap& style_to_index_map);
v8::Isolate* m_isolate;
Member<InspectedFrames> m_inspectedFrames;

Powered by Google App Engine
This is Rietveld 408576698