Rename DOM.getLayoutTreeNodes to CSS.getLayoutTreeAndStyles

third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 12 matching lines @@
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef InspectorDOMAgent_h
 #define InspectorDOMAgent_h
 
+#include <unordered_map>
+
 #include "core/CoreExport.h"
 #include "core/events/EventListenerMap.h"
 #include "core/inspector/InspectorBaseAgent.h"
 #include "core/inspector/InspectorHighlight.h"
 #include "core/inspector/protocol/DOM.h"
 #include "core/style/ComputedStyleConstants.h"
 #include "platform/geometry/FloatQuad.h"
 #include "wtf/HashMap.h"
 #include "wtf/HashSet.h"
 #include "wtf/RefPtr.h"
@@ skipping 74 matching lines @@
   HeapVector<Member<Document>> documents();
   void reset();
 
   // Methods called from the frontend for DOM nodes inspection.
   void enable(ErrorString*) override;
   void disable(ErrorString*) override;
   void getDocument(ErrorString*,
                    std::unique_ptr<protocol::DOM::Node>* root) override;
   void getLayoutTreeNodes(
       ErrorString*,
+      std::unique_ptr<protocol::Array<String>> style_whitelist,
       std::unique_ptr<protocol::Array<protocol::DOM::LayoutTreeNode>>*
-          layoutTreeNodes) override;
+          layout_tree_nodes,
+      std::unique_ptr<protocol::Array<protocol::DOM::ComputedStyle>>*
+          computed_styles) override;
   void collectClassNamesFromSubtree(
       ErrorString*,
       int nodeId,
       std::unique_ptr<protocol::Array<String>>* classNames) override;
   void requestChildNodes(ErrorString*,
                          int nodeId,
                          const Maybe<int>& depth) override;
   void querySelector(ErrorString*,
                      int nodeId,
                      const String& selector,
@@ skipping 209 matching lines @@
   void discardFrontendBindings();
 
   void innerHighlightQuad(std::unique_ptr<FloatQuad>,
                           const Maybe<protocol::DOM::RGBA>& color,
                           const Maybe<protocol::DOM::RGBA>& outlineColor);
 
   bool pushDocumentUponHandlelessOperation(ErrorString*);
 
   Member<InspectorRevalidateDOMTask> revalidateTask();
 
-  void visitLayoutTreeNodes(Node*,
-                            protocol::Array<protocol::DOM::LayoutTreeNode>&);
+  using ComputedStyleArray =
+      std::vector<std::unique_ptr<blink::protocol::DOM::ComputedStyleProperty>>;
+
+  using ComputedStylesMap = std::unordered_map<ComputedStyleArray, int>;
+
+  void visitLayoutTreeNodes(
+      Node* node,
+      protocol::Array<protocol::DOM::LayoutTreeNode>& layout_tree_nodes,

[dgozman, 2016/10/12 21:00:40]

blink uses camelCaseNames for now.

[alex clarke (OOO till 29th), 2016/10/13 20:25:10]

OK :(

+      protocol::Array<String>* style_whitelist,
+      ComputedStylesMap& style_to_index_map);
+
+  int getStyleIndexForNode(Node* node,
+                           protocol::Array<String>* style_whitelist,
+                           ComputedStylesMap& style_to_index_map);
 
   v8::Isolate* m_isolate;
   Member<InspectedFrames> m_inspectedFrames;
   v8_inspector::V8InspectorSession* m_v8Session;
   Client* m_client;
   Member<DOMListener> m_domListener;
   Member<NodeToIdMap> m_documentNodeToIdMap;
   // Owns node mappings for dangling nodes.
   HeapVector<Member<NodeToIdMap>> m_danglingNodeToIdMaps;
   HeapHashMap<int, Member<Node>> m_idToNode;
   HeapHashMap<int, Member<NodeToIdMap>> m_idToNodesMap;
   HashSet<int> m_childrenRequested;
   HashSet<int> m_distributedNodesRequested;
   HashMap<int, int> m_cachedChildCount;
   int m_lastNodeId;
   Member<Document> m_document;
   typedef HeapHashMap<String, HeapVector<Member<Node>>> SearchResults;
   SearchResults m_searchResults;
   Member<InspectorRevalidateDOMTask> m_revalidateTask;
   Member<InspectorHistory> m_history;
   Member<DOMEditor> m_domEditor;
   bool m_suppressAttributeModifiedEvent;
   int m_backendNodeIdToInspect;
 };
 
 }  // namespace blink
 
 #endif  // !defined(InspectorDOMAgent_h)