Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2413683003: Fix a bug where we were forcing pdf intents to stay in Chrome. (Closed)

Created:
4 years, 2 months ago by Maria
Modified:
4 years, 2 months ago
Reviewers:
qinmin
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug where we were forcing pdf intents to stay in Chrome. BUG=653052 Committed: https://crrev.com/051ff0a3ae183adb3b790c043c8cc5d61488aebe Cr-Commit-Position: refs/heads/master@{#425061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Maria
4 years, 2 months ago (2016-10-12 21:15:52 UTC) #2
qinmin
lgtm
4 years, 2 months ago (2016-10-13 16:20:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413683003/1
4 years, 2 months ago (2016-10-13 16:22:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 16:52:59 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 16:55:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/051ff0a3ae183adb3b790c043c8cc5d61488aebe
Cr-Commit-Position: refs/heads/master@{#425061}

Powered by Google App Engine
This is Rietveld 408576698