Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3926)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 2413683003: Fix a bug where we were forcing pdf intents to stay in Chrome. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index 26fc2766c40d9b78fb071382f3621bbbfdb3c564..3ea16d40ba99efc23a7827278b811739df8b2a1b 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -753,6 +753,21 @@ public class ExternalNavigationHandlerTest extends NativeLibraryTestBase {
.expecting(OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);
}
+
+ @SmallTest
+ public void testPdfDownloadHappensInChrome() {
+ checkUrl(CALENDAR_URL + "/file.pdf")
+ .expecting(OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);
+ }
+
+ @SmallTest
+ public void testIntentToPdfFileOpensApp() {
+ checkUrl("intent://yoursite.com/mypdf.pdf#Intent;action=VIEW;category=BROWSABLE;"
+ + "scheme=http;package=com.adobe.reader;end;")
+ .expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
+ START_OTHER_ACTIVITY);
+ }
+
@SmallTest
public void testReferrerExtra() {
String referrer = "http://www.google.com";
@@ -1129,7 +1144,7 @@ public class ExternalNavigationHandlerTest extends NativeLibraryTestBase {
@Override
public boolean isPdfDownload(String url) {
- return false;
+ return url.endsWith(".pdf");
}
@Override
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698