chrome/browser/data_use_measurement/data_use_web_contents_observer.h - Issue 2413663003: Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/data_use_measurement/data_use_web_contents_observer.h

Issue 2413663003: Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (Closed)

Patch Set: Use OnURLRequestDestroyed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc ('k') | chrome/browser/data_use_measurement/data_use_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/data_use_measurement/data_use_web_contents_observer.h

diff --git a/chrome/browser/data_use_measurement/data_use_web_contents_observer.h b/chrome/browser/data_use_measurement/data_use_web_contents_observer.h

index 308b3b521ec0c10846ec29a8fadfdf9e9166e6b1..978ec4733b5f1299a239d25e0171ab868fe4d0ef 100644

--- a/chrome/browser/data_use_measurement/data_use_web_contents_observer.h

+++ b/chrome/browser/data_use_measurement/data_use_web_contents_observer.h

@@ -32,22 +32,13 @@ class DataUseWebContentsObserver

~DataUseWebContentsObserver() override;

- // WebContentsObserver:

- // Called when a render frame host is created.

+ // WebContentsObserver implementation:

void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;

- // Called when a render frame host is deleted.

void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;

- // Called when a navigation is started.

void DidStartNavigation(

content::NavigationHandle* navigation_handle) override;

- // Called when a navigation is completed.

- void DidFinishNavigation(

+ void ReadyToCommitNavigation(

content::NavigationHandle* navigation_handle) override;

- // Called when a navigation is redirected.

void DidRedirectNavigation(

content::NavigationHandle* navigation_handle) override;