chrome/browser/data_use_measurement/data_use_web_contents_observer.cc - Issue 2413663003: Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

Issue 2413663003: Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (Closed)

Patch Set: Use OnURLRequestDestroyed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/data_use_measurement/data_use_web_contents_observer.h ('k') | components/data_use_measurement/core/data_use_ascriber.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

diff --git a/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc b/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

index 7d396bc9850ea27d36aa960e81d32d54a31400d4..cc3ff91fe44a378b2e3794e789a856b7ff1298af 100644

--- a/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

+++ b/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc

@@ -67,9 +67,9 @@ void DataUseWebContentsObserver::DidStartNavigation(

service_->DidStartNavigation(navigation_handle);

}

-void DataUseWebContentsObserver::DidFinishNavigation(

+void DataUseWebContentsObserver::ReadyToCommitNavigation(

content::NavigationHandle* navigation_handle) {

- service_->DidFinishNavigation(navigation_handle);

+ service_->ReadyToCommitNavigation(navigation_handle);

}

void DataUseWebContentsObserver::DidRedirectNavigation(