Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2413663003: Expose GlobalRequestID in NavigationHandle and ResourceRequestInfo. (Closed)
Patch Set: Add comments. Relocate method. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index eae9cd46bb8b6910c79c93eb67b4ac1215d7c657..d731dfa404a9a466d7ed09f5e89dbc92a4f16342 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -6,6 +6,7 @@
#define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
#include <memory>
+#include <string>
#include "content/common/content_export.h"
#include "content/public/browser/navigation_throttle.h"
@@ -20,6 +21,7 @@ class HttpResponseHeaders;
} // namespace net
namespace content {
+struct GlobalRequestID;
class NavigationData;
class NavigationThrottle;
class RenderFrameHost;
@@ -125,6 +127,9 @@ class CONTENT_EXPORT NavigationHandle {
// handlers.
virtual bool IsExternalProtocol() = 0;
+ // Whether the network response has started.
+ virtual bool HasNetworkResponseStarted() = 0;
+
// Navigation control flow --------------------------------------------------
// The net error code if an error happened prior to commit. Otherwise it will
@@ -176,6 +181,10 @@ class CONTENT_EXPORT NavigationHandle {
virtual void CancelDeferredNavigation(
NavigationThrottle::ThrottleCheckResult result) = 0;
+ // This is valid after the network response has started. Returns the ID of the
+ // MAIN_FRAME URLRequest associated with this navigation.
clamy 2016/11/04 14:44:17 Actually, considering the case of transfer navigat
Not at Google. Contact bengr 2016/11/07 22:17:18 Done. I'm guessing you mean ReadyToCommitNavigati
+ virtual const GlobalRequestID& GetGlobalRequestID() = 0;
+
// Testing methods ----------------------------------------------------------
//
// The following methods should be used exclusively for writing unit tests.

Powered by Google App Engine
This is Rietveld 408576698