Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2413663002: Remove embeddedSearch.searchBox.focus (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years, 2 months ago
Reviewers:
Jered
CC:
chromium-reviews, extensions-reviews_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove embeddedSearch.searchBox.focus It's not used, and it's not documented at http://dev.chromium.org/embeddedsearch BUG=628207 Committed: https://crrev.com/ee9c349c46c19a87b67b72bb143d806efd9b5fd5 Cr-Commit-Position: refs/heads/master@{#424746}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M chrome/renderer/resources/extensions/searchbox_api.js View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Marc Treib
PTAL!
4 years, 2 months ago (2016-10-12 13:09:45 UTC) #2
Jered
On 2016/10/12 13:09:45, Marc Treib wrote: > PTAL! lgtm
4 years, 2 months ago (2016-10-12 14:23:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413663002/20001
4 years, 2 months ago (2016-10-12 15:36:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 15:41:16 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 15:45:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee9c349c46c19a87b67b72bb143d806efd9b5fd5
Cr-Commit-Position: refs/heads/master@{#424746}

Powered by Google App Engine
This is Rietveld 408576698