Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4513)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 2413663002: Remove embeddedSearch.searchBox.focus (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/searchbox/searchbox.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index 76bcea81a76ef99bbce8e5ae27c44723d2d6258d..e15a73818bdf57f6f90e29da55060719a52a0c69 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -418,9 +418,6 @@ class SearchBoxExtensionWrapper : public v8::Extension {
static void DeleteMostVisitedItem(
const v8::FunctionCallbackInfo<v8::Value>& args);
- // Focuses the omnibox.
- static void Focus(const v8::FunctionCallbackInfo<v8::Value>& args);
-
// Gets Most Visited Items.
static void GetMostVisitedItems(
const v8::FunctionCallbackInfo<v8::Value>& args);
@@ -591,8 +588,6 @@ SearchBoxExtensionWrapper::GetNativeFunctionTemplate(
return v8::FunctionTemplate::New(isolate, CheckIsUserSyncingHistory);
if (name->Equals(v8::String::NewFromUtf8(isolate, "DeleteMostVisitedItem")))
return v8::FunctionTemplate::New(isolate, DeleteMostVisitedItem);
- if (name->Equals(v8::String::NewFromUtf8(isolate, "Focus")))
- return v8::FunctionTemplate::New(isolate, Focus);
if (name->Equals(v8::String::NewFromUtf8(isolate, "GetMostVisitedItems")))
return v8::FunctionTemplate::New(isolate, GetMostVisitedItems);
if (name->Equals(v8::String::NewFromUtf8(isolate, "GetMostVisitedItemData")))
@@ -695,16 +690,6 @@ void SearchBoxExtensionWrapper::DeleteMostVisitedItem(
}
// static
-void SearchBoxExtensionWrapper::Focus(
- const v8::FunctionCallbackInfo<v8::Value>& args) {
- content::RenderView* render_view = GetRenderView();
- if (!render_view) return;
-
- DVLOG(1) << render_view << " Focus";
- SearchBox::Get(render_view)->Focus();
-}
-
-// static
void SearchBoxExtensionWrapper::GetMostVisitedItems(
const v8::FunctionCallbackInfo<v8::Value>& args) {
content::RenderView* render_view = GetRenderView();
« no previous file with comments | « chrome/renderer/searchbox/searchbox.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698