third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp - Issue 2413633002: Prune createVisiblePositionDeprecated from EditingUtilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

Issue 2413633002: Prune createVisiblePositionDeprecated from EditingUtilities (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingUtilities.cpp ('k') | third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

index c1f5955226c34a0d4875813dd1ea5273751c634b..a834b43569a48db44f7d59ea1428e0a7afd4ad2d 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

@@ -832,6 +832,7 @@ void ApplyStyleCommand::applyInlineStyle(EditingStyle* style,

if (editingState->isAborted())

return;

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

yosin_UTC9 2016/10/12 07:32:00 How about moving updateStyleAndLayoutXXX() to just

Xiaocheng 2016/10/12 07:45:56 The call at L803 seems pretty normal to me. The ne

styleToApply = styleWithoutEmbedding;

}