Prune createVisiblePositionDeprecated from EditingUtilities

third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2008, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 814 matching lines @@
 
       if (!embeddingStyle) {
         styleWithoutEmbedding = style->copy();
         embeddingStyle = styleWithoutEmbedding->extractAndRemoveTextDirection();
       }
       fixRangeAndApplyInlineStyle(embeddingStyle, embeddingApplyStart,
                                   embeddingApplyEnd, editingState);
       if (editingState->isAborted())
         return;
 
+      document().updateStyleAndLayoutIgnorePendingStylesheets();

[yosin_UTC9, 2016/10/12 07:32:00]

How about moving updateStyleAndLayoutXXX() to just before
fixRangeAndApplyInlineStyle() to be more clear where we need updateSAL().

It seems we can move updateSAL() at L803 for fixRangeAndApplyInlineStyle() at
L830.

[Xiaocheng, 2016/10/12 07:45:56]

The call at L803 seems pretty normal to me. The new updateSAL call is move to
just above fixRangeAndApplyInlineStyle

       styleToApply = styleWithoutEmbedding;
     }
   }
 
   fixRangeAndApplyInlineStyle(styleToApply, start, end, editingState);
   if (editingState->isAborted())
     return;
 
   // Remove dummy style spans created by splitting text elements.
   cleanupUnstyledAppleStyleSpans(startDummySpanAncestor, editingState);
@@ skipping 1182 matching lines @@
 
 DEFINE_TRACE(ApplyStyleCommand) {
   visitor->trace(m_style);
   visitor->trace(m_start);
   visitor->trace(m_end);
   visitor->trace(m_styledInlineElement);
   CompositeEditCommand::trace(visitor);
 }
 
 }  // namespace blink