MD Settings: allow changing to GTK+ theme on Linux

MD Settings: allow changing to GTK+ theme on Linux

R=dpapad@chromium.org
BUG=632376
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734
Cr-Commit-Position: refs/heads/master@{#425149}

[Dan Beam, 2016-10-13 00:34:20]

Description was changed from

==========
MD Settings: allow changing to GTK+ theme on Linux

R=dpapad@chromium.org
BUG=632376
==========

to

==========
MD Settings: allow changing to GTK+ theme on Linux

R=dpapad@chromium.org
BUG=632376
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-13 00:40:09]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[Dan Beam, 2016-10-13 00:40:13]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-10-13 00:40:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 00:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 00:55:47]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2016-10-13 05:13:02]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 05:13:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 05:59:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 05:59:53]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dpapad, 2016-10-13 18:31:20]

https://codereview.chromium.org/2413623004/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/appearance_handler.cc (left):

https://codereview.chromium.org/2413623004/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/appearance_handler.cc:62:
CallJavascriptFunction("cr.webUIListenerCallback",
Why don't we need to listen to this anymore?

[Dan Beam, 2016-10-13 18:56:54]

https://codereview.chromium.org/2413623004/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/appearance_handler.cc (left):

https://codereview.chromium.org/2413623004/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/appearance_handler.cc:62:
CallJavascriptFunction("cr.webUIListenerCallback",
On 2016/10/13 18:31:20, dpapad wrote:
> Why don't we need to listen to this anymore?

because observing the prefs is basically the same thing

[Dan Beam, 2016-10-13 18:56:59]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 18:57:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:51:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:51:45]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-13 20:17:52]

lgtm

[Dan Beam, 2016-10-13 20:26:14]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:26:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 20:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:37:42]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2016-10-13 20:39:02]

dbeam@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Dan Beam, 2016-10-13 20:39:02]

+stevenjb@ for prefs_util.cc stamp

[stevenjb, 2016-10-13 20:52:56]

RS LGTM

[stevenjb, 2016-10-13 20:53:06]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:53:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:00:21]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-13 21:03:53]

Description was changed from

==========
MD Settings: allow changing to GTK+ theme on Linux

R=dpapad@chromium.org
BUG=632376
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: allow changing to GTK+ theme on Linux

R=dpapad@chromium.org
BUG=632376
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734
Cr-Commit-Position: refs/heads/master@{#425149}
==========

[commit-bot: I haz the power, 2016-10-13 21:03:55]

Patchset 3 (id:??) landed as
https://crrev.com/128f6569dc555f54ec1f09dd117ac73311597734
Cr-Commit-Position: refs/heads/master@{#425149}