Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3346)

Unified Diff: chrome/browser/ui/webui/settings/appearance_handler.h

Issue 2413623004: MD Settings: allow changing to GTK+ theme on Linux (Closed)
Patch Set: rejigger tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/appearance_handler.h
diff --git a/chrome/browser/ui/webui/settings/appearance_handler.h b/chrome/browser/ui/webui/settings/appearance_handler.h
index 8452d5d06bd04d4841dcda321e409d64cf6ce6b8..a00a9637dc7afde3f405d4cd6c67dbeb720ea059 100644
--- a/chrome/browser/ui/webui/settings/appearance_handler.h
+++ b/chrome/browser/ui/webui/settings/appearance_handler.h
@@ -7,8 +7,6 @@
#include "base/macros.h"
#include "chrome/browser/ui/webui/settings/settings_page_ui_handler.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
namespace base {
class ListValue;
@@ -23,8 +21,7 @@ class Profile;
namespace settings {
// Chrome "Appearance" settings page UI handler.
-class AppearanceHandler : public SettingsPageUIHandler,
- public content::NotificationObserver {
+class AppearanceHandler : public SettingsPageUIHandler {
public:
explicit AppearanceHandler(content::WebUI* webui);
~AppearanceHandler() override;
@@ -35,19 +32,13 @@ class AppearanceHandler : public SettingsPageUIHandler,
void OnJavascriptDisallowed() override;
private:
- // content::NotificationObserver implementation.
- void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ // Changes the UI theme of the browser to the default theme.
+ void HandleUseDefaultTheme(const base::ListValue* args);
- // Whether the theme can be reset.
- bool ResetThemeEnabled() const;
-
- // Resets the UI theme of the browser to the default theme.
- void HandleResetTheme(const base::ListValue* args);
-
- // Sends the enabled state of the reset-theme control to the JS.
- void HandleGetResetThemeEnabled(const base::ListValue* args);
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
+ // Changes the UI theme of the browser to the system (GTK+) theme.
+ void HandleUseSystemTheme(const base::ListValue* args);
+#endif
#if defined(OS_CHROMEOS)
// Open the wallpaper manager app.
@@ -56,9 +47,6 @@ class AppearanceHandler : public SettingsPageUIHandler,
Profile* profile_; // Weak pointer.
- // Used to register for relevant notifications.
- content::NotificationRegistrar registrar_;
-
DISALLOW_COPY_AND_ASSIGN(AppearanceHandler);
};

Powered by Google App Engine
This is Rietveld 408576698