pkg/analysis_server/benchmark/perf/performance_tests.dart - Issue 2413573003: Replace expect() with outOfTestExpect() in Analysis Server performance benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/benchmark/perf/performance_tests.dart

Issue 2413573003: Replace expect() with outOfTestExpect() in Analysis Server performance benchmark. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analysis_server/benchmark/perf/performance_tests.dart

diff --git a/pkg/analysis_server/benchmark/perf/performance_tests.dart b/pkg/analysis_server/benchmark/perf/performance_tests.dart

index 20828c7cbecb42f910b037ab1d1a8d8b16bca2d8..742171e42e34c8941dfb4971c9282298fbf5d396 100644

--- a/pkg/analysis_server/benchmark/perf/performance_tests.dart

+++ b/pkg/analysis_server/benchmark/perf/performance_tests.dart

@@ -43,7 +43,7 @@ abstract class AbstractAnalysisServerPerformanceTest

});

Completer serverConnected = new Completer();

onServerConnected.listen((_) {

- expect(serverConnected.isCompleted, isFalse);

+ outOfTestExpect(serverConnected.isCompleted, isFalse);

serverConnected.complete();

});

return startServer(checked: false).then((_) {