Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: pkg/analysis_server/benchmark/perf/memory_tests.dart

Issue 2413573003: Replace expect() with outOfTestExpect() in Analysis Server performance benchmark. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/benchmark/perf/memory_tests.dart
diff --git a/pkg/analysis_server/benchmark/perf/memory_tests.dart b/pkg/analysis_server/benchmark/perf/memory_tests.dart
index ec625733a6a09ebeee051ea1b46105898e2492fd..4fb9b6c80b67f4c203b0183d482eae976bbb4fc8 100644
--- a/pkg/analysis_server/benchmark/perf/memory_tests.dart
+++ b/pkg/analysis_server/benchmark/perf/memory_tests.dart
@@ -65,7 +65,7 @@ class AnalysisServerMemoryUsageTest
});
Completer serverConnected = new Completer();
onServerConnected.listen((_) {
- expect(serverConnected.isCompleted, isFalse);
+ outOfTestExpect(serverConnected.isCompleted, isFalse);
serverConnected.complete();
});
return startServer(servicesPort: vmServicePort).then((_) {
@@ -109,8 +109,8 @@ class AnalysisServerMemoryUsageTest
*/
static Future<List<int>> start_waitInitialAnalysis_shutdown(
{List<String> roots, int numOfRepeats}) async {
- expect(roots, isNotNull, reason: 'roots');
- expect(numOfRepeats, isNotNull, reason: 'numOfRepeats');
+ outOfTestExpect(roots, isNotNull, reason: 'roots');
+ outOfTestExpect(numOfRepeats, isNotNull, reason: 'numOfRepeats');
// Repeat.
List<int> sizes = <int>[];
for (int i = 0; i < numOfRepeats; i++) {
« no previous file with comments | « pkg/analysis_server/benchmark/perf/benchmark_scenario.dart ('k') | pkg/analysis_server/benchmark/perf/performance_tests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698