Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2413573003: Replace expect() with outOfTestExpect() in Analysis Server performance benchmark. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace expect() with outOfTestExpect() in Analysis Server performance benchmark. In package:test function expect() does not want to be used outside of test() methods. So, we need a partial copy for using it in integration tesitng code, and performance benchmarks. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/33ecec5d4fa90e4c357e9247993dd487ca116d67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -64 lines) Patch
M pkg/analysis_server/benchmark/perf/benchmark_scenario.dart View 8 chunks +31 lines, -23 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/memory_tests.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/performance_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 11 chunks +27 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 5 chunks +40 lines, -8 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 2 months ago (2016-10-12 19:30:38 UTC) #1
Paul Berry
lgtm
4 years, 2 months ago (2016-10-12 19:35:45 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 33ecec5d4fa90e4c357e9247993dd487ca116d67 (presubmit successful).
4 years, 2 months ago (2016-10-12 19:57:14 UTC) #4
Brian Wilkerson
4 years, 2 months ago (2016-10-13 13:52:56 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698