Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3424)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java

Issue 2413533003: [Payments] Normalize billing address before sending to the merchant. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
index c799a7814d292cdd7bc2d8c0ae2cbdbe67d61180..8c48f833c963c7442c39e8a22c966c9ad7c7c5f6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java
@@ -4,11 +4,11 @@
package org.chromium.chrome.browser.payments;
+import org.json.JSONObject;
+
import org.chromium.chrome.browser.payments.ui.PaymentOption;
import org.chromium.payments.mojom.PaymentItem;
-import org.json.JSONObject;
-
import java.util.List;
/**
@@ -28,6 +28,11 @@ public abstract class PaymentInstrument extends PaymentOption {
void onInstrumentDetailsReady(String methodName, String stringifiedDetails);
/**
+ * Called when loading the instrument details.
please use gerrit instead 2016/10/17 20:44:18 Please elaborate a bit more on this comment. This
sebsg 2016/10/18 14:38:19 Done.
+ */
+ void loadingInstrumentDetails();
please use gerrit instead 2016/10/17 20:44:18 Let's move this callback to be the first one in th
sebsg 2016/10/18 14:38:19 Done.
+
+ /**
* Called if unable to retrieve instrument details.
*/
void onInstrumentDetailsError();

Powered by Google App Engine
This is Rietveld 408576698