[Payments] Normalize billing address before sending to the merchant.

chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.payments;
 
+import org.json.JSONObject;
+
 import org.chromium.chrome.browser.payments.ui.PaymentOption;
 import org.chromium.payments.mojom.PaymentItem;
 
-import org.json.JSONObject;
-
 import java.util.List;
 
 /**
  * The base class for a single payment instrument, e.g., a credit card.
  */
 public abstract class PaymentInstrument extends PaymentOption {
     /**
      * The interface for the requester of instrument details.
      */
     public interface DetailsCallback {
         /**
          * Called after retrieving instrument details.
          *
          * @param methodName         Method name. For example, "visa".
          * @param stringifiedDetails JSON-serialized object. For example, {"card": "123"}.
          */
         void onInstrumentDetailsReady(String methodName, String stringifiedDetails);
 
         /**
+         * Called when loading the instrument details.

[please use gerrit instead, 2016/10/17 20:44:18]

Please elaborate a bit more on this comment. This callback is important because
the instrument is not showing any UI, but the onInstrumentDetailsReady/Error()
has not been called yet. So the PaymentRequestUI should show it's own
"Loading..." UI at this time.

[sebsg, 2016/10/18 14:38:19]

Done.

+         */
+        void loadingInstrumentDetails();

[please use gerrit instead, 2016/10/17 20:44:18]

Let's move this callback to be the first one in the interface. When thinking
about the time progression, this is called before
onInstrumentDetailsReady/Error(). So it would make sense to also place
"loading..." callback above these "ready" and "error" callbacks.

[sebsg, 2016/10/18 14:38:19]

Done.

+
+        /**
          * Called if unable to retrieve instrument details.
          */
         void onInstrumentDetailsError();
     }
 
     protected PaymentInstrument(String id, String label, String sublabel, int icon) {
         super(id, label, sublabel, icon);
     }
 
     /**
@@ skipping 17 matching lines @@
      */
     public abstract void getDetails(String merchantName, String origin, PaymentItem total,
             List<PaymentItem> cart, JSONObject details, DetailsCallback callback);
 
     /**
      * Cleans up any resources held by the payment instrument. For example, closes server
      * connections.
      */
     public abstract void dismiss();
 }