Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2413473004: UMA histogram for longest renderer main thread usage for page save to MHTML. (Closed)

Created:
4 years, 2 months ago by carlosk
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

UMA histogram for longest renderer main thread usage for page save to MHTML. The information about the time taken by the main render process thread for saving a page to MHTML is the main feedback we have to see how much the operation impacts user experience. The existing UMA that tracks this information, PageSerialization.MhtmlGeneration.RendererMainThreadTime.SingleFrame, is not directly useful for the purpose above because it includes reports for all frames in a page save operation. For pages with many frames, most of them are very simple and quickly saved, while one -- generally the main frame -- is the slowest. So we have a huge amount of low-value samples pulling the statistics down. This change adds a new histogram, PageSerialization.MhtmlGeneration.RendererMainThreadTime.SlowestFrame, that reports only the longest of all times from the former one in a single HTML page saving operation, which is the most important one in terms of user experience. BUG=645686 Review-Url: https://codereview.chromium.org/2400383002 Cr-Commit-Position: refs/heads/master@{#424312} (cherry picked from commit 90bf4f0c77709ddb65b1f8d86e04065aacae02ac) Committed: https://chromium.googlesource.com/chromium/src/+/67c28ff356fd4c8115cefb2ea2fc9bf8510db02c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M content/browser/download/mhtml_generation_manager.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
carlosk
4 years, 2 months ago (2016-10-12 18:08:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
67c28ff356fd4c8115cefb2ea2fc9bf8510db02c (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698