Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2400383002: UMA histogram for longest renderer main thread usage for page save to MHTML. (Closed)

Created:
4 years, 2 months ago by carlosk
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asanka, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UMA histogram for longest renderer main thread usage for page save to MHTML. The information about the time taken by the main render process thread for saving a page to MHTML is the main feedback we have to see how much the operation impacts user experience. The existing UMA that tracks this information, PageSerialization.MhtmlGeneration.RendererMainThreadTime.SingleFrame, is not directly useful for the purpose above because it includes reports for all frames in a page save operation. For pages with many frames, most of them are very simple and quickly saved, while one -- generally the main frame -- is the slowest. So we have a huge amount of low-value samples pulling the statistics down. This change adds a new histogram, PageSerialization.MhtmlGeneration.RendererMainThreadTime.SlowestFrame, that reports only the longest of all times from the former one in a single HTML page saving operation, which is the most important one in terms of user experience. BUG=645686 Committed: https://crrev.com/90bf4f0c77709ddb65b1f8d86e04065aacae02ac Cr-Commit-Position: refs/heads/master@{#424312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M content/browser/download/mhtml_generation_manager.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
carlosk
isherman@: Please review changes in histograms.xml. lukasza@, nasko@: Please review changes in mhtml_generation_manager.cc.
4 years, 2 months ago (2016-10-08 00:53:06 UTC) #4
Łukasz Anforowicz
LGTM
4 years, 2 months ago (2016-10-08 01:38:40 UTC) #6
nasko
Rubberstamp LGTM based on lukasza@'s review.
4 years, 2 months ago (2016-10-10 22:10:31 UTC) #9
Ilya Sherman
lgtm
4 years, 2 months ago (2016-10-10 23:32:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400383002/1
4 years, 2 months ago (2016-10-10 23:33:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 00:50:23 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 00:54:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90bf4f0c77709ddb65b1f8d86e04065aacae02ac
Cr-Commit-Position: refs/heads/master@{#424312}

Powered by Google App Engine
This is Rietveld 408576698