Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2413413003: Correctly check if we have a valid page height before checking remaining space. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly check if we have a valid page height before checking remaining space. LayoutState::pageLogicalHeight() is bogus, and the sooner we convince it to take a long walk on the short pier, the better. :( Additionally, bail out earlier from fragmentation-specific code. No need to waste time on calling crossesPageBoundary() when not fragmented. BUG=655911 Committed: https://crrev.com/5fe33d9b08d983eaa6dc22f936f4a5f50442517a Cr-Commit-Position: refs/heads/master@{#425420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/abspos-table-in-nested-multicol-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-14 09:25:23 UTC) #6
eae
LGTM
4 years, 2 months ago (2016-10-14 19:06:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413413003/1
4 years, 2 months ago (2016-10-14 19:10:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413413003/1
4 years, 2 months ago (2016-10-14 19:13:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 19:18:28 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:21:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fe33d9b08d983eaa6dc22f936f4a5f50442517a
Cr-Commit-Position: refs/heads/master@{#425420}

Powered by Google App Engine
This is Rietveld 408576698