third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2413413003: Correctly check if we have a valid page height before checking remaining space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2413413003: Correctly check if we have a valid page height before checking remaining space. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 4efa03050f40a98c87c8f2eb2a29de05de72c16d..eb291d4596f8b4c335f77502abe67e4f1bfbd140 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -5504,7 +5504,7 @@ LayoutUnit LayoutBox::pageRemainingLogicalHeightForOffset(

bool LayoutBox::crossesPageBoundary(LayoutUnit offset,

LayoutUnit logicalHeight) const {

- if (!view()->layoutState()->pageLogicalHeight())

+ if (!pageLogicalHeightForOffset(offset))

return false;

return pageRemainingLogicalHeightForOffset(offset, AssociateWithLatterPage) <

logicalHeight;