Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Side by Side Diff: src/core/SkColorSpaceXform_Base.h

Issue 2413383002: Cache dst LUTs in SkColorSpaceXform (Closed)
Patch Set: Ref the storage on SkColorSpaceXform Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkColorSpaceXform.cpp ('k') | src/core/SkColorSpace_Base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 Google Inc. 2 * Copyright 2016 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkColorSpaceXform_Base_DEFINED 8 #ifndef SkColorSpaceXform_Base_DEFINED
9 #define SkColorSpaceXform_Base_DEFINED 9 #define SkColorSpaceXform_Base_DEFINED
10 10
11 #include "SkColorSpace.h" 11 #include "SkColorSpace.h"
12 #include "SkColorSpace_Base.h" 12 #include "SkColorSpace_Base.h"
13 #include "SkColorSpaceXform.h" 13 #include "SkColorSpaceXform.h"
14 #include "SkResourceCache.h"
15
16 class SkColorSpaceXform_Base : public SkColorSpaceXform {
17 public:
18 static constexpr int kDstGammaTableSize = 1024;
19
20 protected:
21 virtual bool onApply(ColorFormat dstFormat, void* dst, ColorFormat srcFormat , const void* src,
22 int count, SkAlphaType alphaType) const = 0;
23
24 private:
25 static void BuildDstGammaTables(const uint8_t* outGammaTables[3], uint8_t* g ammaTableStorage,
26 const SkColorSpace* space, bool gammasAreMat ching);
27
28 friend class SkColorSpaceXform;
29 friend class SkColorSpace_Base;
30 };
14 31
15 enum SrcGamma { 32 enum SrcGamma {
16 kLinear_SrcGamma, 33 kLinear_SrcGamma,
17 kTable_SrcGamma, 34 kTable_SrcGamma,
18 }; 35 };
19 36
20 enum DstGamma { 37 enum DstGamma {
21 kLinear_DstGamma, 38 kLinear_DstGamma,
22 kSRGB_DstGamma, 39 kSRGB_DstGamma,
23 k2Dot2_DstGamma, 40 k2Dot2_DstGamma,
24 kTable_DstGamma, 41 kTable_DstGamma,
25 }; 42 };
26 43
27 enum ColorSpaceMatch { 44 enum ColorSpaceMatch {
28 kNone_ColorSpaceMatch, 45 kNone_ColorSpaceMatch,
29 kGamut_ColorSpaceMatch, 46 kGamut_ColorSpaceMatch,
30 kFull_ColorSpaceMatch, 47 kFull_ColorSpaceMatch,
31 }; 48 };
32 49
33 template <SrcGamma kSrc, DstGamma kDst, ColorSpaceMatch kCSM> 50 template <SrcGamma kSrc, DstGamma kDst, ColorSpaceMatch kCSM>
34 class SkColorSpaceXform_Base : public SkColorSpaceXform { 51 class SkColorSpaceXform_XYZ : public SkColorSpaceXform_Base {
35 public:
36 static constexpr int kDstGammaTableSize = 1024;
37
38 protected: 52 protected:
39 bool onApply(ColorFormat dstFormat, void* dst, ColorFormat srcFormat, const void* src, 53 bool onApply(ColorFormat dstFormat, void* dst, ColorFormat srcFormat, const void* src,
40 int count, SkAlphaType alphaType) const override; 54 int count, SkAlphaType alphaType) const override;
41 55
42 private: 56 private:
43 SkColorSpaceXform_Base(SkColorSpace* srcSpace, const SkMatrix44& srcToDst, 57 SkColorSpaceXform_XYZ(SkColorSpace* srcSpace, const SkMatrix44& srcToDst,
44 SkColorSpace* dstSpace); 58 SkColorSpace* dstSpace);
45 59
46 sk_sp<SkColorLookUpTable> fColorLUT; 60 sk_sp<SkColorLookUpTable> fColorLUT;
47 61
48 // Contain pointers into storage or pointers into precomputed tables. 62 // Contain pointers into storage or pointers into precomputed tables.
49 const float* fSrcGammaTables[3]; 63 const float* fSrcGammaTables[3];
64 SkAutoTMalloc<float> fSrcStorage;
50 const uint8_t* fDstGammaTables[3]; 65 const uint8_t* fDstGammaTables[3];
51 SkAutoMalloc fStorage; 66 sk_sp<SkData> fDstStorage;
52 67
53 float fSrcToDst[16]; 68 float fSrcToDst[16];
54 69
55 friend class SkColorSpaceXform; 70 friend class SkColorSpaceXform;
56 friend std::unique_ptr<SkColorSpaceXform> SlowIdentityXform(SkColorSpace* sp ace); 71 friend std::unique_ptr<SkColorSpaceXform> SlowIdentityXform(SkColorSpace* sp ace);
57 }; 72 };
58 73
59 // For testing. Bypasses opts for when src and dst color spaces are equal. 74 // For testing. Bypasses opts for when src and dst color spaces are equal.
60 std::unique_ptr<SkColorSpaceXform> SlowIdentityXform(SkColorSpace* space); 75 std::unique_ptr<SkColorSpaceXform> SlowIdentityXform(SkColorSpace* space);
61 76
62 #endif 77 #endif
OLDNEW
« no previous file with comments | « src/core/SkColorSpaceXform.cpp ('k') | src/core/SkColorSpace_Base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698