Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2413363002: added SkSL support for mustForceNegatedAtanParamToFloat cap (Closed)

Created:
4 years, 2 months ago by ethannicholas
Modified:
4 years, 2 months ago
Reviewers:
dogben, egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

added SkSL support for mustForceNegatedAtanParamToFloat cap BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2413363002 Committed: https://skia.googlesource.com/skia/+/ad146f6ef5d2de94bd2d8c678757a6274844d20e

Patch Set 1 #

Patch Set 2 : updated comment #

Patch Set 3 : updated comment again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -11 lines) Patch
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M src/sksl/SkSLMain.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/SkSLGLSLTest.cpp View 2 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
ethannicholas
4 years, 2 months ago (2016-10-13 20:41:03 UTC) #5
dogben
lgtm
4 years, 2 months ago (2016-10-14 00:03:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413363002/40001
4 years, 2 months ago (2016-10-14 13:08:48 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 13:40:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ad146f6ef5d2de94bd2d8c678757a6274844d20e

Powered by Google App Engine
This is Rietveld 408576698