Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBase.cpp

Issue 2413353003: Clean up PerformanceCompositeTiming and PerformanceRenderTiming (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBase.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
index 8d971ff3cc1e152f9a4f21ecc2232a92cb403412..3a79e0cb247da8d37d478770764a687740dcd4b5 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
@@ -34,10 +34,8 @@
#include "core/dom/Document.h"
#include "core/events/Event.h"
#include "core/frame/UseCounter.h"
-#include "core/timing/PerformanceCompositeTiming.h"
#include "core/timing/PerformanceLongTaskTiming.h"
#include "core/timing/PerformanceObserver.h"
-#include "core/timing/PerformanceRenderTiming.h"
#include "core/timing/PerformanceResourceTiming.h"
#include "core/timing/PerformanceUserTiming.h"
#include "platform/network/ResourceTimingInfo.h"
@@ -314,12 +312,6 @@ void PerformanceBase::addRenderTiming(Document* initiatorDocument,
double finishTime) {
if (isFrameTimingBufferFull() && !hasObserverFor(PerformanceEntry::Render))
return;
-
- PerformanceEntry* entry = PerformanceRenderTiming::create(
- initiatorDocument, sourceFrame, startTime, finishTime);
- notifyObserversOfEntry(*entry);
- if (!isFrameTimingBufferFull())
- addFrameTimingBuffer(*entry);
}
void PerformanceBase::addCompositeTiming(Document* initiatorDocument,
Stephen Chennney 2016/10/17 17:42:50 This one also always does nothing.
@@ -327,12 +319,6 @@ void PerformanceBase::addCompositeTiming(Document* initiatorDocument,
double startTime) {
if (isFrameTimingBufferFull() && !hasObserverFor(PerformanceEntry::Composite))
return;
-
- PerformanceEntry* entry = PerformanceCompositeTiming::create(
- initiatorDocument, sourceFrame, startTime);
- notifyObserversOfEntry(*entry);
- if (!isFrameTimingBufferFull())
- addFrameTimingBuffer(*entry);
}
void PerformanceBase::addFrameTimingBuffer(PerformanceEntry& entry) {
« no previous file with comments | « third_party/WebKit/Source/core/timing/BUILD.gn ('k') | third_party/WebKit/Source/core/timing/PerformanceCompositeTiming.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698