Clean up PerformanceCompositeTiming and PerformanceRenderTiming

third_party/WebKit/Source/core/timing/PerformanceBase.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 16 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/timing/PerformanceBase.h"
 
 #include "core/dom/Document.h"
 #include "core/events/Event.h"
 #include "core/frame/UseCounter.h"
-#include "core/timing/PerformanceCompositeTiming.h"
 #include "core/timing/PerformanceLongTaskTiming.h"
 #include "core/timing/PerformanceObserver.h"
-#include "core/timing/PerformanceRenderTiming.h"
 #include "core/timing/PerformanceResourceTiming.h"
 #include "core/timing/PerformanceUserTiming.h"
 #include "platform/network/ResourceTimingInfo.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "wtf/CurrentTime.h"
 #include <algorithm>
 
 namespace blink {
 
 using PerformanceObserverVector = HeapVector<Member<PerformanceObserver>>;
@@ skipping 250 matching lines @@
     dispatchEvent(Event::create(EventTypeNames::resourcetimingbufferfull));
     dispatchEvent(
         Event::create(EventTypeNames::webkitresourcetimingbufferfull));
   }
 }
 
 bool PerformanceBase::isResourceTimingBufferFull() {
   return m_resourceTimingBuffer.size() >= m_resourceTimingBufferSize;
 }
 
 void PerformanceBase::addRenderTiming(Document* initiatorDocument,

[Stephen Chennney, 2016/10/17 17:42:50]

These can just always immediately return without doing anything now.

[panicker, 2016/10/17 17:50:20]

Yes addRenderTiming and addCompositeTiming should be deleted.

                                       unsigned sourceFrame,
                                       double startTime,
                                       double finishTime) {
   if (isFrameTimingBufferFull() && !hasObserverFor(PerformanceEntry::Render))
     return;
-
-  PerformanceEntry* entry = PerformanceRenderTiming::create(
-      initiatorDocument, sourceFrame, startTime, finishTime);
-  notifyObserversOfEntry(*entry);
-  if (!isFrameTimingBufferFull())
-    addFrameTimingBuffer(*entry);
 }
 
 void PerformanceBase::addCompositeTiming(Document* initiatorDocument,

[Stephen Chennney, 2016/10/17 17:42:50]

This one also always does nothing.

                                          unsigned sourceFrame,
                                          double startTime) {
   if (isFrameTimingBufferFull() && !hasObserverFor(PerformanceEntry::Composite))
     return;
-
-  PerformanceEntry* entry = PerformanceCompositeTiming::create(
-      initiatorDocument, sourceFrame, startTime);
-  notifyObserversOfEntry(*entry);
-  if (!isFrameTimingBufferFull())
-    addFrameTimingBuffer(*entry);
 }
 
 void PerformanceBase::addFrameTimingBuffer(PerformanceEntry& entry) {
   m_frameTimingBuffer.append(&entry);
 
   if (isFrameTimingBufferFull())
     dispatchEvent(Event::create(EventTypeNames::frametimingbufferfull));
 }
 
 bool PerformanceBase::isFrameTimingBufferFull() {
@@ skipping 148 matching lines @@
   visitor->trace(m_frameTimingBuffer);
   visitor->trace(m_resourceTimingBuffer);
   visitor->trace(m_userTiming);
   visitor->trace(m_observers);
   visitor->trace(m_activeObservers);
   visitor->trace(m_suspendedObservers);
   EventTargetWithInlineData::trace(visitor);
 }
 
 }  // namespace blink