[Sync] Move the last things out of core/.

[Sync] Move the last things out of core/.

- InternalComponentsFactory is renamed EngineComponentsFactory, which
  is slightly more descriptive.
- syncapi_internal is renamed engine_util, which is slightly more
  descriptive and accurate.
- A bunch of FOR_EACH_OBSERVER uses were removed due to a new presubmit
  against using the macro.
- I have no idea why the header for sync_db_util was in base/.

engine/
  activation_context
  configure_reason
  connection_status
  data_type_association_stats
  data_type_debug_info_listener
  fake_model_type_connector
  fake_model_type_processor
  fake_sync_manager
  internal_components_factory -> engine_components_factory
  internal_components_factory_impl -> engine_components_factory_impl
  model_type_connector
  model_type_processor
  model_type_processor_proxy
  non_blocking_sync_common
  shutdown_reason
  sync_auth_provider
  sync_encryption_handler
  sync_manager
  sync_manager_factory
  sync_manager_factory_for_profile_sync_test
  syncapi_internal -> engine_util
  test_internal_components_factory -> test_engine_components_factory

engine_impl/
  debug_info_event_listener
  js_mutation_event_observer
  js_sync_encryption_handler_observer
  js_sync_manager_observer
  model_type_connector_proxy
  sync_encryption_handler_impl
  sync_manager_for_profile_sync_test
  sync_manager_impl
  test_entry_factory

engine_impl/events/
  protocol_event_buffer

syncable/
  sync_db_util

BUG=631271
TBR=jochen

Committed: https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028
Cr-Commit-Position: refs/heads/master@{#425491}

[maxbogue, 2016-10-14 17:11:53]

The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 17:12:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-14 17:15:34]

maxbogue@chromium.org changed reviewers:
+ skym@chromium.org

[maxbogue, 2016-10-14 17:15:36]

Sky, PTAL!

[skym, 2016-10-14 18:42:14]

lgtm

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
File components/sync/engine/engine_components_factory.h (right):

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
components/sync/engine/engine_components_factory.h:35: class
EngineComponentsFactory {
This class needs a comment. You're in the best position to write that than we'll
ever have.

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
components/sync/engine/engine_components_factory.h:51: enum
PreCommitUpdatesPolicy {
I wonder if we can remove this (admittedly out of scope).

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
components/sync/engine/engine_components_factory.h:76: STORAGE_IN_MEMORY,
Do we need to plumb this through for USS? Do we need a new bug to track this?

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
components/sync/engine/engine_components_factory.h:107: virtual Switches
GetSwitches() const = 0;
Seems unfortunate that this is part of the interface.

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/sync_encryption_handler_impl.cc (right):

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine_impl...
components/sync/engine_impl/sync_encryption_handler_impl.cc:1660: for (auto&
observer : observers_) {
Can you throw in a comment noting that these 3 loops are to avoid accidentally
introducing a bug, and not because we know this is the only/better way?

[maxbogue, 2016-10-14 19:11:17]

maxbogue@chromium.org changed reviewers:
+ davidben@chromium.org, jochen@chromium.org, xyzzyz@chromium.org

[maxbogue, 2016-10-14 19:11:18]

+jochen for other components/ OWNERS
+davidben for net/ DEPS
+xyzzyz for third_party/protobuf/ DEPS

This change is just transferring the DEPS from one directory to another, not
actually introducing them.

[davidben, 2016-10-14 19:24:47]

net DEPS lgtm

[commit-bot: I haz the power, 2016-10-14 19:37:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 19:37:02]

Dry run: This issue passed the CQ dry run.

[xyzzyz, 2016-10-14 20:05:02]

protobuf deps lgtm

[maxbogue, 2016-10-14 20:25:01]

TBR jochen@ for the 4 deps files that I removed the outdated
components/sync/core dep from.

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
File components/sync/engine/engine_components_factory.h (right):

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
components/sync/engine/engine_components_factory.h:35: class
EngineComponentsFactory {
On 2016/10/14 18:42:13, skym wrote:
> This class needs a comment. You're in the best position to write that than
we'll
> ever have.

Done.

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
components/sync/engine/engine_components_factory.h:51: enum
PreCommitUpdatesPolicy {
On 2016/10/14 18:42:14, skym wrote:
> I wonder if we can remove this (admittedly out of scope).

Probably!

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
components/sync/engine/engine_components_factory.h:76: STORAGE_IN_MEMORY,
On 2016/10/14 18:42:14, skym wrote:
> Do we need to plumb this through for USS? Do we need a new bug to track this?

No, in USS land if we want to test something regarding storage it must go
through the model type.

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine/engi...
components/sync/engine/engine_components_factory.h:107: virtual Switches
GetSwitches() const = 0;
On 2016/10/14 18:42:14, skym wrote:
> Seems unfortunate that this is part of the interface.

¯\_(ツ)_/¯

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine_impl...
File components/sync/engine_impl/sync_encryption_handler_impl.cc (right):

https://codereview.chromium.org/2413313004/diff/1/components/sync/engine_impl...
components/sync/engine_impl/sync_encryption_handler_impl.cc:1660: for (auto&
observer : observers_) {
On 2016/10/14 18:42:14, skym wrote:
> Can you throw in a comment noting that these 3 loops are to avoid accidentally
> introducing a bug, and not because we know this is the only/better way?

Done.

[maxbogue, 2016-10-14 20:25:17]

Description was changed from

==========
[Sync] Move the last things out of core/.

- InternalComponentsFactory is renamed EngineComponentsFactory, which
  is slightly more descriptive.
- syncapi_internal is renamed engine_util, which is slightly more
  descriptive and accurate.
- A bunch of FOR_EACH_OBSERVER uses were removed due to a new presubmit
  against using the macro.
- I have no idea why the header for sync_db_util was in base/.

engine/
  activation_context
  configure_reason
  connection_status
  data_type_association_stats
  data_type_debug_info_listener
  fake_model_type_connector
  fake_model_type_processor
  fake_sync_manager
  internal_components_factory -> engine_components_factory
  internal_components_factory_impl -> engine_components_factory_impl
  model_type_connector
  model_type_processor
  model_type_processor_proxy
  non_blocking_sync_common
  shutdown_reason
  sync_auth_provider
  sync_encryption_handler
  sync_manager
  sync_manager_factory
  sync_manager_factory_for_profile_sync_test
  syncapi_internal -> engine_util
  test_internal_components_factory -> test_engine_components_factory

engine_impl/
  debug_info_event_listener
  js_mutation_event_observer
  js_sync_encryption_handler_observer
  js_sync_manager_observer
  model_type_connector_proxy
  sync_encryption_handler_impl
  sync_manager_for_profile_sync_test
  sync_manager_impl
  test_entry_factory

engine_impl/events/
  protocol_event_buffer

syncable/
  sync_db_util

BUG=631271
==========

to

==========
[Sync] Move the last things out of core/.

- InternalComponentsFactory is renamed EngineComponentsFactory, which
  is slightly more descriptive.
- syncapi_internal is renamed engine_util, which is slightly more
  descriptive and accurate.
- A bunch of FOR_EACH_OBSERVER uses were removed due to a new presubmit
  against using the macro.
- I have no idea why the header for sync_db_util was in base/.

engine/
  activation_context
  configure_reason
  connection_status
  data_type_association_stats
  data_type_debug_info_listener
  fake_model_type_connector
  fake_model_type_processor
  fake_sync_manager
  internal_components_factory -> engine_components_factory
  internal_components_factory_impl -> engine_components_factory_impl
  model_type_connector
  model_type_processor
  model_type_processor_proxy
  non_blocking_sync_common
  shutdown_reason
  sync_auth_provider
  sync_encryption_handler
  sync_manager
  sync_manager_factory
  sync_manager_factory_for_profile_sync_test
  syncapi_internal -> engine_util
  test_internal_components_factory -> test_engine_components_factory

engine_impl/
  debug_info_event_listener
  js_mutation_event_observer
  js_sync_encryption_handler_observer
  js_sync_manager_observer
  model_type_connector_proxy
  sync_encryption_handler_impl
  sync_manager_for_profile_sync_test
  sync_manager_impl
  test_entry_factory

engine_impl/events/
  protocol_event_buffer

syncable/
  sync_db_util

BUG=631271
TBR=jochen
==========

[maxbogue, 2016-10-14 20:25:48]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2016-10-14 20:25:49]

The patchset sent to the CQ was uploaded after l-g-t-m from xyzzyz@chromium.org,
skym@chromium.org, davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2413313004/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-10-14 20:26:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 22:17:41]

Description was changed from

==========
[Sync] Move the last things out of core/.

- InternalComponentsFactory is renamed EngineComponentsFactory, which
  is slightly more descriptive.
- syncapi_internal is renamed engine_util, which is slightly more
  descriptive and accurate.
- A bunch of FOR_EACH_OBSERVER uses were removed due to a new presubmit
  against using the macro.
- I have no idea why the header for sync_db_util was in base/.

engine/
  activation_context
  configure_reason
  connection_status
  data_type_association_stats
  data_type_debug_info_listener
  fake_model_type_connector
  fake_model_type_processor
  fake_sync_manager
  internal_components_factory -> engine_components_factory
  internal_components_factory_impl -> engine_components_factory_impl
  model_type_connector
  model_type_processor
  model_type_processor_proxy
  non_blocking_sync_common
  shutdown_reason
  sync_auth_provider
  sync_encryption_handler
  sync_manager
  sync_manager_factory
  sync_manager_factory_for_profile_sync_test
  syncapi_internal -> engine_util
  test_internal_components_factory -> test_engine_components_factory

engine_impl/
  debug_info_event_listener
  js_mutation_event_observer
  js_sync_encryption_handler_observer
  js_sync_manager_observer
  model_type_connector_proxy
  sync_encryption_handler_impl
  sync_manager_for_profile_sync_test
  sync_manager_impl
  test_entry_factory

engine_impl/events/
  protocol_event_buffer

syncable/
  sync_db_util

BUG=631271
TBR=jochen
==========

to

==========
[Sync] Move the last things out of core/.

- InternalComponentsFactory is renamed EngineComponentsFactory, which
  is slightly more descriptive.
- syncapi_internal is renamed engine_util, which is slightly more
  descriptive and accurate.
- A bunch of FOR_EACH_OBSERVER uses were removed due to a new presubmit
  against using the macro.
- I have no idea why the header for sync_db_util was in base/.

engine/
  activation_context
  configure_reason
  connection_status
  data_type_association_stats
  data_type_debug_info_listener
  fake_model_type_connector
  fake_model_type_processor
  fake_sync_manager
  internal_components_factory -> engine_components_factory
  internal_components_factory_impl -> engine_components_factory_impl
  model_type_connector
  model_type_processor
  model_type_processor_proxy
  non_blocking_sync_common
  shutdown_reason
  sync_auth_provider
  sync_encryption_handler
  sync_manager
  sync_manager_factory
  sync_manager_factory_for_profile_sync_test
  syncapi_internal -> engine_util
  test_internal_components_factory -> test_engine_components_factory

engine_impl/
  debug_info_event_listener
  js_mutation_event_observer
  js_sync_encryption_handler_observer
  js_sync_manager_observer
  model_type_connector_proxy
  sync_encryption_handler_impl
  sync_manager_for_profile_sync_test
  sync_manager_impl
  test_entry_factory

engine_impl/events/
  protocol_event_buffer

syncable/
  sync_db_util

BUG=631271
TBR=jochen
==========

[commit-bot: I haz the power, 2016-10-14 22:17:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-14 22:20:26]

Description was changed from

==========
[Sync] Move the last things out of core/.

- InternalComponentsFactory is renamed EngineComponentsFactory, which
  is slightly more descriptive.
- syncapi_internal is renamed engine_util, which is slightly more
  descriptive and accurate.
- A bunch of FOR_EACH_OBSERVER uses were removed due to a new presubmit
  against using the macro.
- I have no idea why the header for sync_db_util was in base/.

engine/
  activation_context
  configure_reason
  connection_status
  data_type_association_stats
  data_type_debug_info_listener
  fake_model_type_connector
  fake_model_type_processor
  fake_sync_manager
  internal_components_factory -> engine_components_factory
  internal_components_factory_impl -> engine_components_factory_impl
  model_type_connector
  model_type_processor
  model_type_processor_proxy
  non_blocking_sync_common
  shutdown_reason
  sync_auth_provider
  sync_encryption_handler
  sync_manager
  sync_manager_factory
  sync_manager_factory_for_profile_sync_test
  syncapi_internal -> engine_util
  test_internal_components_factory -> test_engine_components_factory

engine_impl/
  debug_info_event_listener
  js_mutation_event_observer
  js_sync_encryption_handler_observer
  js_sync_manager_observer
  model_type_connector_proxy
  sync_encryption_handler_impl
  sync_manager_for_profile_sync_test
  sync_manager_impl
  test_entry_factory

engine_impl/events/
  protocol_event_buffer

syncable/
  sync_db_util

BUG=631271
TBR=jochen
==========

to

==========
[Sync] Move the last things out of core/.

- InternalComponentsFactory is renamed EngineComponentsFactory, which
  is slightly more descriptive.
- syncapi_internal is renamed engine_util, which is slightly more
  descriptive and accurate.
- A bunch of FOR_EACH_OBSERVER uses were removed due to a new presubmit
  against using the macro.
- I have no idea why the header for sync_db_util was in base/.

engine/
  activation_context
  configure_reason
  connection_status
  data_type_association_stats
  data_type_debug_info_listener
  fake_model_type_connector
  fake_model_type_processor
  fake_sync_manager
  internal_components_factory -> engine_components_factory
  internal_components_factory_impl -> engine_components_factory_impl
  model_type_connector
  model_type_processor
  model_type_processor_proxy
  non_blocking_sync_common
  shutdown_reason
  sync_auth_provider
  sync_encryption_handler
  sync_manager
  sync_manager_factory
  sync_manager_factory_for_profile_sync_test
  syncapi_internal -> engine_util
  test_internal_components_factory -> test_engine_components_factory

engine_impl/
  debug_info_event_listener
  js_mutation_event_observer
  js_sync_encryption_handler_observer
  js_sync_manager_observer
  model_type_connector_proxy
  sync_encryption_handler_impl
  sync_manager_for_profile_sync_test
  sync_manager_impl
  test_entry_factory

engine_impl/events/
  protocol_event_buffer

syncable/
  sync_db_util

BUG=631271
TBR=jochen

Committed: https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028
Cr-Commit-Position: refs/heads/master@{#425491}
==========

[commit-bot: I haz the power, 2016-10-14 22:20:28]

Patchset 2 (id:??) landed as
https://crrev.com/f690e24c680fb3c07fa7ea4a064b4244689da028
Cr-Commit-Position: refs/heads/master@{#425491}