components/sync/engine_impl/js_sync_manager_observer.cc - Issue 2413313004: [Sync] Move the last things out of core/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sync/engine_impl/js_sync_manager_observer.cc

Issue 2413313004: [Sync] Move the last things out of core/. (Closed)

Patch Set: Address comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/sync/engine_impl/js_sync_manager_observer.h ('k') | components/sync/engine_impl/js_sync_manager_observer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/sync/core_impl/js_sync_manager_observer.h"	5 #include "components/sync/engine_impl/js_sync_manager_observer.h"

6	6

7 #include <cstddef>	7 #include <cstddef>

8	8

9 #include "base/location.h"	9 #include "base/location.h"

10 #include "base/logging.h"	10 #include "base/logging.h"

11 #include "base/strings/string_number_conversions.h"	11 #include "base/strings/string_number_conversions.h"

12 #include "base/values.h"	12 #include "base/values.h"

13 #include "components/sync/base/model_type.h"	13 #include "components/sync/base/model_type.h"

14 #include "components/sync/engine/cycle/sync_cycle_snapshot.h"	14 #include "components/sync/engine/cycle/sync_cycle_snapshot.h"

15 #include "components/sync/engine/sync_string_conversions.h"	15 #include "components/sync/engine/sync_string_conversions.h"

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
85 const std::string& name,	85 const std::string& name,

86 const JsEventDetails& details) {	86 const JsEventDetails& details) {

87 if (!event_handler_.IsInitialized()) {	87 if (!event_handler_.IsInitialized()) {

88 NOTREACHED();	88 NOTREACHED();

89 return;	89 return;

90 }	90 }

91 event_handler_.Call(from_here, &JsEventHandler::HandleJsEvent, name, details);	91 event_handler_.Call(from_here, &JsEventHandler::HandleJsEvent, name, details);

92 }	92 }

93	93

94 } // namespace syncer	94 } // namespace syncer

OLD	NEW