Issue 2413223002: Update layout in CompositeEditCommand::moveParagraphs for TextIterator::rangeLength

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2413223002: Update layout in CompositeEditCommand::moveParagraphs for TextIterator::rangeLength (Closed)

Created:
4 years, 2 months ago by Xiaocheng

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update layout in CompositeEditCommand::moveParagraphs for TextIterator::rangeLength A call site in CompositeEditCommand::moveParagraphs was missed when hoisting the layout update call from TextIterator::rangeLength. This patch hence adds back the missing call. BUG=653819 TEST=n/a; this is a patch to an ongoing refactoring work Review-Url: https://codereview.chromium.org/2410513003 Cr-Commit-Position: refs/heads/master@{#424369} (cherry picked from commit e5e7e69014427cd09887d3a407e8cbb3059eb3b4)

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Xiaocheng

4 years, 2 months ago (2016-10-13 09:35:56 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
244a1dd19a561232a7f732e4bbd7b690f4e255bc.

Expand Messages | Collapse Messages