Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2410513003: Update layout in CompositeEditCommand::moveParagraphs for TextIterator::rangeLength (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update layout in CompositeEditCommand::moveParagraphs for TextIterator::rangeLength A call site in CompositeEditCommand::moveParagraphs was missed when hoisting the layout update call from TextIterator::rangeLength. This patch hence adds back the missing call. BUG=653819 TEST=n/a; this is a patch to an ongoing refactoring work Committed: https://crrev.com/e5e7e69014427cd09887d3a407e8cbb3059eb3b4 Cr-Commit-Position: refs/heads/master@{#424369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-11 03:53:43 UTC) #5
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-11 03:59:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410513003/1
4 years, 2 months ago (2016-10-11 03:59:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 04:40:41 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 04:43:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5e7e69014427cd09887d3a407e8cbb3059eb3b4
Cr-Commit-Position: refs/heads/master@{#424369}

Powered by Google App Engine
This is Rietveld 408576698