Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2413213002: Allow lazy parsing of eval-created functions (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow lazy parsing of eval-created functions I don't see a reason why we can't benefit from preparsing such functions. We don't necessarily compile them, so fully parsing them when unnecessary is just additional overhead. BUG=v8:5501 Committed: https://crrev.com/2325ad7e62f44f993561063bf21d33a0c76dbb19 Cr-Commit-Position: refs/heads/master@{#40248}

Patch Set 1 #

Patch Set 2 : Add currently failing test for strict-mode eval which doesn't pollute the outer scope #

Patch Set 3 : disallow preparsing without scope resolution of strict-mode evaled functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M src/ast/scopes.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -3 lines 0 comments Download
A + test/mjsunit/preparse-toplevel-strict-eval.js View 1 1 chunk +6 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-13 09:00:55 UTC) #2
marja
lgtm
4 years, 2 months ago (2016-10-13 09:18:10 UTC) #4
marja
lgtm
4 years, 2 months ago (2016-10-13 09:44:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413213002/40001
4 years, 2 months ago (2016-10-13 09:44:57 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 10:08:06 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 10:08:29 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2325ad7e62f44f993561063bf21d33a0c76dbb19
Cr-Commit-Position: refs/heads/master@{#40248}

Powered by Google App Engine
This is Rietveld 408576698