src/parsing/parser.cc - Issue 2413213002: Allow lazy parsing of eval-created functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser.cc

Issue 2413213002: Allow lazy parsing of eval-created functions (Closed)

Patch Set: disallow preparsing without scope resolution of strict-mode evaled functions Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/parser.cc

diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc

index b018b7d8ab7be49aeffe25e29d19e92b40a28978..292293987b0471c017bc28529440f6ae2b7a5e27 100644

--- a/src/parsing/parser.cc

+++ b/src/parsing/parser.cc

@@ -791,9 +791,6 @@ FunctionLiteral* Parser::DoParseProgram(ParseInfo* info) {

DCHECK_NOT_NULL(outer);

parsing_module_ = info->is_module();

if (info->is_eval()) {

- if (!outer->is_script_scope() || is_strict(info->language_mode())) {

- parsing_mode = PARSE_EAGERLY;

- }

outer = NewEvalScope(outer);

} else if (parsing_module_) {

DCHECK_EQ(outer, info->script_scope());

« no previous file with comments | « src/ast/scopes.cc ('k') | test/mjsunit/preparse-toplevel-strict-eval.js » ('j') | no next file with comments »