Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2413163003: Revert of chromeos: Add VLOG(1)s around renderer-freezing for suspend. (Closed)

Created:
4 years, 2 months ago by Daniel Erat
Modified:
4 years, 2 months ago
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, derat+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chromeos: Add VLOG(1)s around renderer-freezing for suspend. (patchset #3 id:40001 of https://codereview.chromium.org/2395293003/ ) Reason for revert: I believe that the underlying bug has been fixed, so this logging is no longer needed. Original issue's description: > chromeos: Add VLOG(1)s around renderer-freezing for suspend. > > Add temporary VLOG(1) messages to renderer-freezing code to > try to track down the cause of a strange crash. > > BUG=chromium:648580 > > Committed: https://crrev.com/04239907e878ce5b4c2f4dfdadb04667f739c433 > Cr-Commit-Position: refs/heads/master@{#423750} TBR=chirantan@chromium.org,llozano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:648580 Committed: https://crrev.com/fe73615f5de8ae035c27aa20ac954b4d9e802fa2 Cr-Commit-Position: refs/heads/master@{#425109}

Patch Set 1 #

Patch Set 2 : manual revert to resolve conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -58 lines) Patch
M chrome/browser/chromeos/power/renderer_freezer.cc View 1 4 chunks +0 lines, -10 lines 0 comments Download
M chromeos/dbus/power_manager_client.cc View 1 6 chunks +12 lines, -48 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Daniel Erat
Created Revert of chromeos: Add VLOG(1)s around renderer-freezing for suspend.
4 years, 2 months ago (2016-10-13 18:11:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413163003/1
4 years, 2 months ago (2016-10-13 18:12:15 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/86183) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-13 18:15:09 UTC) #5
Daniel Erat
manual revert to resolve conflicts
4 years, 2 months ago (2016-10-13 18:18:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2413163003/60001
4 years, 2 months ago (2016-10-13 18:20:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 2 months ago (2016-10-13 18:51:16 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 18:53:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe73615f5de8ae035c27aa20ac954b4d9e802fa2
Cr-Commit-Position: refs/heads/master@{#425109}

Powered by Google App Engine
This is Rietveld 408576698