Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/chromeos/power/renderer_freezer.cc

Issue 2413163003: Revert of chromeos: Add VLOG(1)s around renderer-freezing for suspend. (Closed)
Patch Set: manual revert to resolve conflicts Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/power_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/power/renderer_freezer.cc
diff --git a/chrome/browser/chromeos/power/renderer_freezer.cc b/chrome/browser/chromeos/power/renderer_freezer.cc
index e5459fdf3ac7ac1727becbb626e2483b1a9710d8..93b4e665896b08a203c650c4285f134878fccb99 100644
--- a/chrome/browser/chromeos/power/renderer_freezer.cc
+++ b/chrome/browser/chromeos/power/renderer_freezer.cc
@@ -34,16 +34,12 @@ namespace chromeos {
RendererFreezer::RendererFreezer(
std::unique_ptr<RendererFreezer::Delegate> delegate)
: delegate_(std::move(delegate)), weak_factory_(this) {
- // TODO(derat): Remove after http://crbug.com/648580 is fixed.
- VLOG(1) << "Creating RendererFreezer " << this;
delegate_->CheckCanFreezeRenderers(
base::Bind(&RendererFreezer::OnCheckCanFreezeRenderersComplete,
weak_factory_.GetWeakPtr()));
}
RendererFreezer::~RendererFreezer() {
- // TODO(derat): Remove after http://crbug.com/648580 is fixed.
- VLOG(1) << "Destroying RendererFreezer " << this;
for (int rph_id : gcm_extension_processes_) {
content::RenderProcessHost* host =
content::RenderProcessHost::FromID(rph_id);
@@ -53,8 +49,6 @@ RendererFreezer::~RendererFreezer() {
}
void RendererFreezer::SuspendImminent() {
- // TODO(derat): Remove after http://crbug.com/648580 is fixed.
- VLOG(1) << "Asking delegate to freeze renderers";
// All the delegate's operations are asynchronous so they may not complete
// before the system suspends. This is ok since the renderers only need to be
// frozen in dark resume. As long as they do get frozen soon after we enter
@@ -63,8 +57,6 @@ void RendererFreezer::SuspendImminent() {
}
void RendererFreezer::SuspendDone() {
- // TODO(derat): Remove after http://crbug.com/648580 is fixed.
- VLOG(1) << "Asking delegate to thaw renderers";
delegate_->ThawRenderers(base::Bind(&RendererFreezer::OnThawRenderersComplete,
weak_factory_.GetWeakPtr()));
}
@@ -138,8 +130,6 @@ void RendererFreezer::OnCheckCanFreezeRenderersComplete(bool can_freeze) {
}
void RendererFreezer::OnThawRenderersComplete(bool success) {
- // TODO(derat): Remove after http://crbug.com/648580 is fixed.
- VLOG(1) << "Thawing renderers complete";
if (success)
return;
« no previous file with comments | « no previous file | chromeos/dbus/power_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698